Add missing SWT FAQ pages#1731
Conversation
|
@tivervac Thanks. From a quick gance the change looks good. I assume lots of this information needs updates based on work @HeikoKlare (Edge) and @HannesWell (GTK) are doing but that could be done IMHO in another PR. I have a close look next week and will merge it if I do not find issues. |
|
I've made a note to myself to take a look at and update the FAQ related to Edge soon. They also look rather outdated to me. |
|
@vogella the single CI failure doesn't seem to be because of my changes. Do these look good or should we wait for Heiko? |
HeikoKlare
left a comment
There was a problem hiding this comment.
Thank you the implicit reminder 🙂 I have just prepared an adaptation of the Edge FAQ. I would propose to keep this PR as is and make everything else (including my proposal) as a follow-up change. What do you think?
Just two thoughts regarding this PR:
- When making my changes, I have been searching some time for the document, because most files are named
FAQ_*while some of the new files are namedFAQ-*. It's rather nitpicky, but should/could we align the names to have them properly ordered? - Some of the new FAQ pages are missing a headline (exactly the ones having a differently formatted file name). Should we add a headline to them?
|
Yes, that makes sense. Done. |
|
Great, thank you for the quick reply! I would be in favor of merging your changes then to finally have them in. In case there is need for adaptation, we can still make follow-up changes. |
ea6e3c4 to
821c368
Compare
* Cleanup fenced code blocks * Some small markdown cleanup
|
Thanks @HeikoKlare and @tivervac for handling this one. I lost track of this one. |
@vogella Sorry for the delay. This PR is the followup for eclipse-platform/eclipse.platform.swt#1634
I can remove the cleanup if required, I'm mostly interested in the new pages.