Skip to content

impl: logging support #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
arkjedrz wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

impl: logging support #206

arkjedrz wants to merge 3 commits into from

Conversation

@arkjedrz
Copy link
Contributor

@arkjedrz arkjedrz commented Jan 7, 2026

  • Use mw_log as a logging frontend.
  • Use C++-based mw_logger for Bazel targets.
  • Use stdout_logger for Cargo targets.
  • Add more logs.
  • Fix tests.
  • Check only stdout_logger feature with cargo clippy in CI.

@arkjedrz
impl: logging support
7f22bb6 
- Support for `mw_log` with C++ backend for Bazel.
- Support for `log` for Cargo.
- Add more logs.
- Fix tests.
- Disable `score-log` feature in CI check.
@arkjedrz arkjedrz marked this pull request as draft January 7, 2026 15:01
@arkjedrz arkjedrz requested a review from pawelrutkaq January 7, 2026 15:01
@github-actions
Copy link

github-actions bot commented Jan 7, 2026 •
edited
Loading

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 5587d3ec-c3a4-4e86-9683-51955ef7a80a
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rust_qnx8_toolchain+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-oEubHgeZDdT0svMmBKJx7c3/2TdSI/vfwRUyDn+TPGA="
DEBUG: Repository rust_qnx8_toolchain+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_rust_policies', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_bazel_platforms', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_process', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
Analyzing: target //:license-check (5 packages loaded, 0 targets configured)
Analyzing: target //:license-check (5 packages loaded, 0 targets configured)

Analyzing: target //:license-check (89 packages loaded, 10 targets configured)

Analyzing: target //:license-check (94 packages loaded, 10 targets configured)

Analyzing: target //:license-check (159 packages loaded, 2311 targets configured)

Analyzing: target //:license-check (167 packages loaded, 7409 targets configured)

Analyzing: target //:license-check (167 packages loaded, 7409 targets configured)

INFO: Analyzed target //:license-check (170 packages loaded, 9425 targets configured).
[11 / 14] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 66 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 25.690s, Critical Path: 0.34s
INFO: 14 processes: 5 disk cache hit, 9 internal.
INFO: Build completed successfully, 14 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@arkjedrz arkjedrz force-pushed the arkjedrz_enable-logging-2 branch from 77bc368 to d9faad5 Compare January 7, 2026 15:06
pawelrutkaq
pawelrutkaq reviewed Jan 7, 2026
View reviewed changes
src/rust/rust_kvs_tool/BUILD
"@score_baselibs_rust//src/log/mw_log",
"@score_crates//:pico_args",
"@score_crates//:tinyjson",
"@score_logging//src/rust/mw_logger",
Copy link
Contributor

@pawelrutkaq pawelrutkaq Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't rustc_flags comes from mw_logger ?

Copy link
Contributor Author

@arkjedrz arkjedrz Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't work without them.

MODULE.bazel
commit = "5a70133dd8bd632f5c07f200a5ee4bc9f507c23b",
remote = "https://github.com/eclipse-score/communication.git",
)

Copy link
Contributor

@pawelrutkaq pawelrutkaq Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we wait with PR until logging is fixed.

@arkjedrz arkjedrz force-pushed the arkjedrz_enable-logging-2 branch 3 times, most recently from 20e5a3c to 8286df7 Compare January 7, 2026 15:25
@arkjedrz
impl: remove log support
a474245 
- Replace `log` crate with `mw_log` and provided Rust backend.
- Bump toolchain version in CI.
@arkjedrz arkjedrz force-pushed the arkjedrz_enable-logging-2 branch from 8286df7 to b065c66 Compare January 8, 2026 09:20
@arkjedrz
impl: use "PERS" context for this component
ba914d3 
- Provide `log` module as a `mw_log` proxy.
- Use `"PERS"` context for all persistency logs.
@arkjedrz arkjedrz force-pushed the arkjedrz_enable-logging-2 branch from b065c66 to ba914d3 Compare January 8, 2026 09:55
@arkjedrz arkjedrz requested a review from vinodreddy-g January 8, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pawelrutkaq pawelrutkaq pawelrutkaq left review comments

@vinodreddy-g vinodreddy-g Awaiting requested review from vinodreddy-g

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arkjedrz @pawelrutkaq