Skip to content

refactor: eslint no-process-exit, turn off warning in CLI #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: eslint no-process-exit, turn off warning in CLI #1433

wants to merge 1 commit into from

Conversation

danielpeintner
Copy link
Member

see #1430

@danielpeintner danielpeintner requested a review from relu91 as a code owner October 7, 2025 09:24
@danielpeintner danielpeintner mentioned this pull request Oct 7, 2025
Open
14 tasks
@danielpeintner
Copy link
Member Author

According to https://nodejs.org/api/process.html#processexitcode it is not best practice to use process.exit(1) and one could/should use process.exitCode = 1.
Anyhow, in the CLI case I think we should exit and hence I ignored those 3 issues in the CLI code.

Any thoughts?

@danielpeintner danielpeintner changed the title refactor: turn off warning/error in CLI refactor: eslint no-process-exit, turn off warning in CLI Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@relu91 relu91 Awaiting requested review from relu91 relu91 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@danielpeintner