Skip to content

refactor: eslint no-process-exit, turn off warning in CLI #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: eslint no-process-exit, turn off warning in CLI #1433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export default defineConfig([
"n/no-extraneous-import": "off", // https://github.com/eclipse-thingweb/node-wot/issues/1430
"n/no-deprecated-api": "off", // https://github.com/eclipse-thingweb/node-wot/issues/1430
"n/no-unpublished-import": "off", // https://github.com/eclipse-thingweb/node-wot/issues/1430
"n/no-process-exit": "off", // https://github.com/eclipse-thingweb/node-wot/issues/1430
"n/no-process-exit": "error",
"n/hashbang": "warn",

// *************** Ensure that only used dependencies are imported ***************
Expand Down
2 changes: 2 additions & 0 deletions packages/cli/src/cli-default-servient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ export default class DefaultServient extends Servient {
const listener = (err: Error) => {
this.logScriptError(`Asynchronous script error '${filename}'`, err);
// TODO: clean up script resources
// eslint-disable-next-line n/no-process-exit
process.exit(1);
};
process.prependListener("uncaughtException", listener);
Expand Down Expand Up @@ -231,6 +232,7 @@ export default class DefaultServient extends Servient {
const listener = (err: Error) => {
this.logScriptError(`Asynchronous script error '${filename}'`, err);
// TODO: clean up script resources
// eslint-disable-next-line n/no-process-exit
process.exit(1);
};
process.prependListener("uncaughtException", listener);
Expand Down
1 change: 1 addition & 0 deletions packages/cli/src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,7 @@ buildConfig()
return new DefaultServient(options.clientOnly);
} else {
error(`"WoT-Servient config file error. ${err}`);
// eslint-disable-next-line n/no-process-exit
process.exit(err.errno);
}
})
Expand Down