server: Allow lower case strings for time graph tooltip's element type #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TSP specifies that the element type should be upper case (due to enum). This code change will convert the input value to lower case before comparing the actual string. This will allow TSP clients to slowly update to the TSP compliant values. fixes eclipse-tracecompass-incubator#240 Signed-off-by: Bernd Hufmann <[email protected]>
PatrickTasse
approved these changes
Oct 1, 2025
bhufmann
merged commit 7bdac3b
into
eclipse-tracecompass-incubator:master
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
server: Allow lower case strings for time graph tooltip's element type.
The TSP specifies that the element type should be upper case (due to enum). This code change will convert the input value to lower case before comparing the actual string. This will allow TSP clients to slowly update to the TSP compliant values.
fixes #240
How to test
Follow steps in #240 and verify that test are successful.
Follow-ups
Review checklist