Skip to content

server: Allow lower case strings for time graph tooltip's element type #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhufmann merged 1 commit into from
Oct 1, 2025
Merged

server: Allow lower case strings for time graph tooltip's element type #241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions ...ompass/incubator/internal/trace/server/jersey/rest/core/services/QueryParametersUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,18 +491,21 @@ private static String validateRequestedElement(Map<String, Object> params) {
params.computeIfPresent(DataProviderParameterUtils.REQUESTED_ELEMENT_KEY, (k, v) -> {
if (v instanceof Map) {
Map<String, Object> map = (Map<String, Object>) v;
Object elementType = map.get(ELEMENT_TYPE);
long time = ((Number) map.getOrDefault(TIME, 0L)).longValue();
long duration = ((Number) map.getOrDefault(DURATION, 0L)).longValue();
if (ElementType.STATE.equals(elementType)) {
return new TimeGraphState(time, duration, null, null);
} else if (ElementType.ANNOTATION.equals(elementType)) {
long entryId = ((Number) map.getOrDefault(ENTRY_ID, -1L)).longValue();
return new Annotation(time, duration, entryId, AnnotationType.CHART, null, EMPTY_STYLE);
} else if (ElementType.ARROW.equals(elementType)) {
long sourceId = ((Number) map.getOrDefault(ENTRY_ID, -1L)).longValue();
long destinationId = ((Number) map.getOrDefault(DESTINATION_ID, -1L)).longValue();
return new TimeGraphArrow(sourceId, destinationId, time, duration, EMPTY_STYLE);
Object elementTypeObj = map.get(ELEMENT_TYPE);
if ((elementTypeObj != null)) {
String elementType = elementTypeObj.toString().toLowerCase();
long time = ((Number) map.getOrDefault(TIME, 0L)).longValue();
long duration = ((Number) map.getOrDefault(DURATION, 0L)).longValue();
if (ElementType.STATE.equals(elementType)) {
return new TimeGraphState(time, duration, null, null);
} else if (ElementType.ANNOTATION.equals(elementType)) {
long entryId = ((Number) map.getOrDefault(ENTRY_ID, -1L)).longValue();
return new Annotation(time, duration, entryId, AnnotationType.CHART, null, EMPTY_STYLE);
} else if (ElementType.ARROW.equals(elementType)) {
long sourceId = ((Number) map.getOrDefault(ENTRY_ID, -1L)).longValue();
long destinationId = ((Number) map.getOrDefault(DESTINATION_ID, -1L)).longValue();
return new TimeGraphArrow(sourceId, destinationId, time, duration, EMPTY_STYLE);
}
}
}
return null;
Expand Down
Loading