swagger: Fix specification for sampling in xy output (2) #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was incorrectly specified and didn't match the implementation. Signed-off-by: Siwei Zhang <[email protected]>
Signed-off-by: Bernd Hufmann <[email protected]>
1 task
bhufmann
changed the title
bhufmann
force-pushed
the
newSampling
branch
2 times, most recently
from
437e9ce to
04f8c61
Compare
| } | ||
| } | ||
|
|
||
|
|
| * | ||
| * - Timestamps → flat array → "xValues": [1, 2, 3] | ||
| * - Categories → array of strings → "categories": ["Read", "Write"] | ||
| * - TimeRanges → array of StartEndRange → ["ranges": { "start": 1, "end": 2 }, { "start": 3, "end": 4 }] |
Contributor
There was a problem hiding this comment.
The ranges don't necessarily be time ranges, can be duration/frequency ranges.
Signed-off-by: Bernd Hufmann <[email protected]>
Contributor
Author
|
not needed anymore since it's handled by #238 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was incorrectly specified and didn't match the implementation.
Related issue:
#236
What it does
SeriesModelStartEndRangetoRange(swagger)xValues,xCategoriesandxRangesfor the 3 sampling use cases.SeriesModelandSamplingHow to test
Follow-ups
Review checklist