Sign 3rd party artifacts with Trace Compass's PGP key #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
bhufmann
force-pushed
the
gpg-signing
branch
2 times, most recently
from
a23503f to
19c2095
Compare
This will get the latest code for gpg signing. Change unnecessary cast settings to warning o.e.tc.segmentstore.core to to avoid build failure. Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
force-pushed
the
gpg-signing
branch
from
19c2095 to
e08cdb3
Compare
PatrickTasse
approved these changes
Feb 25, 2025
Both Trace Compass update site and RCP update site will be signed. Signing of RCP update site requires Tycho 4.0.10 or later. Use tycho-gpg-plugin: https://tycho.eclipseprojects.io/doc/4.0.11/tycho-gpg-plugin/sign-p2-artifacts-mojo.html Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
force-pushed
the
gpg-signing
branch
from
e08cdb3 to
d3968bd
Compare
PatrickTasse
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Sign 3rd party artifacts with Trace Compass's PGP key. Both Trace Compass update site and RCP update site will be signed.
Use tycho-gpg-plugin:
https://tycho.eclipseprojects.io/doc/4.0.11/tycho-gpg-plugin/sign-p2-artifacts-mojo.html
Upgrade to Tycho 4.0.11 because signing of RCP update site requires Tycho 4.0.10 or later. The new Tycho required to change unnecessary cast settings to warning o.e.tc.segmentstore.core to to avoid build failure.
How to test
I tested using a test Jenkins job and made sure that gpg signing is executed when using profile
-Psign-update-site. Then I downloaded theartifact.xml.xzfile and checked that the GPG signing is included for thetrace-event-loggerartifact. Note that, this test Jenkins job and result will be only temporary available.To test it one the own laptop is more tricky. You would have to move the gpg signing in a own profile (releng-site and rcp.product pom.xml), generate a local GPG signature, update the
keynamein the root pom.xml and run maven with that profile and-Dgpg-passphrase=....Follow-ups
Review checklist
Signed-off-by: Bernd Hufmann [email protected]