-
Notifications
You must be signed in to change notification settings - Fork 209
simple fix of oracle stream API for RAW column #1498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: turakamou <[email protected]>
vertx-oracle-client/src/main/java/io/vertx/oracleclient/impl/RowReader.java
Outdated
Show resolved
Hide resolved
|
can you describe in your commit : what is the issue and how the commit fixes it |
Oracle will return "[B" as class name for byte[], I don't know why the class loader is not able to load this. So when we try to call getObject for this column, it is called with null class argument. So let's return the correct class in this case. Signed-off-by: turakamou <[email protected]>
|
PS: was I right to propose the commit for master as it will also be needed for 4.x |
|
And I fact I should have check the unitest on master, seems it doesn't compile. |
Fix unit test for master Signed-off-by: turakamou <[email protected]>
|
Should be ok on this test on master |
|
let us run first CI and get @tsegismont to review the patch :-) |
tsegismont
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for looking into this @turakamou
Can you take care of the fix with my suggestions?
vertx-oracle-client/src/main/java/io/vertx/oracleclient/impl/RowReader.java
Outdated
Show resolved
Hide resolved
Take into account tsegismont review comments Signed-off-by: turakamou <[email protected]>
tsegismont
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@turakamou thank you, this looks good to me!
|
@turakamou I'll wait for CI to complete before merging and will take care of backporting. Thanks again! |
|
@turakamou I'll take care of backporting. Thanks again! |
* simple fix of oracle stream API for RAW column Signed-off-by: turakamou <[email protected]> * fixup! simple fix of oracle stream API for RAW column Oracle will return "[B" as class name for byte[], I don't know why the class loader is not able to load this. So when we try to call getObject for this column, it is called with null class argument. So let's return the correct class in this case. Signed-off-by: turakamou <[email protected]> * fixup! simple fix of oracle stream API for RAW column Fix unit test for master Signed-off-by: turakamou <[email protected]> * simple fix of oracle stream API for RAW column Take into account tsegismont review comments Signed-off-by: turakamou <[email protected]> --------- Signed-off-by: turakamou <[email protected]>
|
Thanks a lot to you too for the quick help and merge. |
Backported from eclipse-vertx#1498 Signed-off-by: turakamou <[email protected]>
Backported from #1498 Signed-off-by: turakamou <[email protected]> Co-authored-by: turakamou <[email protected]>
Motivation:
At least version 4.5.13 has this issue
I encountered an exception while using vertx-oracle stream API to fetch data from a RAW column.
There is no issue with the regular "Prepared queries" API
The stack trace is:
Here is a simple fix along with a unit test to prove the fix work.