Skip to content

simple fix of oracle stream API for RAW column #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 17, 2025
Merged

simple fix of oracle stream API for RAW column #1498

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8036db5
simple fix of oracle stream API for RAW column
turakamou Feb 19, 2025
83c2ded
fixup! simple fix of oracle stream API for RAW column
turakamou Mar 14, 2025
2b22fec
fixup! simple fix of oracle stream API for RAW column
turakamou Mar 14, 2025
321dfd2
simple fix of oracle stream API for RAW column
turakamou Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions vertx-oracle-client/src/main/java/io/vertx/oracleclient/impl/RowReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,9 @@ private static Row transform(List<String> ors, RowDesc desc, oracle.jdbc.OracleR

private static Class<?> getType(String cn) {
try {
if (cn.equals(byte[].class.getName())) {
return byte[].class;
}
return OraclePreparedQueryCommand.class.getClassLoader().loadClass(cn);
} catch (ClassNotFoundException e) {
return null;
Expand Down
22 changes: 22 additions & 0 deletions vertx-oracle-client/src/test/java/tests/oracleclient/OracleBinaryDataTypesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,28 @@ private <T> void testDecode(TestContext ctx, String columnName, JDBCType jdbcTyp
}));
}

private void testDecodeUsingStream(TestContext ctx, String columnName, JDBCType jdbcType, Buffer expected) {
pool.getConnection(ctx.asyncAssertSuccess(conn -> {
conn.prepare("SELECT " + columnName + " FROM binary_data_types WHERE id = 1")
.onComplete(ctx.asyncAssertSuccess(preparedStatement -> {
preparedStatement.cursor().read(10).onComplete(ctx.asyncAssertSuccess(result -> {
ctx.assertEquals(1, result.size());
Row row = result.iterator().next();
ctx.assertEquals(expected, row.get(Buffer.class, 0));
ctx.assertEquals(expected, row.get(Buffer.class, columnName));
ColumnDescriptor columnDescriptor = result.columnDescriptors().get(0);
ctx.assertEquals(jdbcType, columnDescriptor.jdbcType());
ctx.assertNotNull(columnDescriptor);
}));
}));
}));
}

@Test
public void testDecodeRawUsingStream(TestContext ctx) {
testDecodeUsingStream(ctx, "test_raw", JDBCType.VARBINARY, Buffer.buffer("See you space cowboy..."));
}

@Test
public void testEncodeNull(TestContext ctx) {
pool
Expand Down
Loading