feat: implement DifferenceFilter to compute the difference between two variables#232
Open
nicrie wants to merge 2 commits intoecmwf:mainfrom
Open
feat: implement DifferenceFilter to compute the difference between two variables#232nicrie wants to merge 2 commits intoecmwf:mainfrom
nicrie wants to merge 2 commits intoecmwf:mainfrom
Conversation
for more information, see https://pre-commit.ci
aaron-hopkinson
requested changes
Feb 18, 2026
Contributor
aaron-hopkinson
left a comment
There was a problem hiding this comment.
Thanks for this. The filter looks good to me.
Would it also be possible to add a test, please? 🙂
| @@ -0,0 +1,74 @@ | |||
| # (C) Copyright 2024 Anemoi contributors. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| # (C) Copyright 2024 Anemoi contributors. | |
| # (C) Copyright 2026- Anemoi contributors. |
| *, | ||
| x: str, | ||
| y: str, | ||
| diff: str, |
Contributor
There was a problem hiding this comment.
I wonder if it's worth having an abs: bool = False argument as well (which optionally takes the absolute value of the difference)? I can imagine that there may cases where the absolute difference is useful (and prevents people having to think about which is X and which is Y)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a$X-Y$ between two matched variables and registers it in the filter registry.
differencefilter that computesWhat problem does this change solve?
New feature: enables simple variable differencing in transform pipelines.
What issue or task does this change relate to?
None.
Additional notes
Is the list of available filters auto-generated? Let me know where to update the source docs if necessary and I can add the difference filter there.
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.