-
Notifications
You must be signed in to change notification settings - Fork 19
feat: implement DifferenceFilter to compute the difference between two variables #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nicrie
wants to merge
2
commits into
ecmwf:main
Choose a base branch
from
nicrie:difference
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| # (C) Copyright 2024 Anemoi contributors. | ||
| # | ||
| # This software is licensed under the terms of the Apache Licence Version 2.0 | ||
| # which can be obtained at http://www.apache.org/licenses/LICENSE-2.0. | ||
| # | ||
| # In applying this licence, ECMWF does not waive the privileges and immunities | ||
| # granted to it by virtue of its status as an intergovernmental organisation | ||
| # nor does it submit to any jurisdiction. | ||
|
|
||
|
|
||
| from typing import Literal | ||
|
|
||
| import earthkit.data as ekd | ||
|
|
||
| from anemoi.transform.filters import filter_registry | ||
| from anemoi.transform.filters.matching import MatchingFieldsFilter | ||
| from anemoi.transform.filters.matching import matching | ||
|
|
||
|
|
||
| @filter_registry.register("difference") | ||
| class DifferenceFilter(MatchingFieldsFilter): | ||
| """A filter to compute a simple difference between two variables. | ||
|
|
||
| This filter converts two fields X and Y to a field representing the difference between the two (X - Y). | ||
|
|
||
| """ | ||
|
|
||
| @matching(select="param", forward=("x", "y"), backward=("diff",)) | ||
| def __init__( | ||
| self, | ||
| *, | ||
| x: str, | ||
| y: str, | ||
| diff: str, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wonder if it's worth having an |
||
| return_inputs: Literal["all", "none"] | list[str] = "all", | ||
| ) -> None: | ||
| """Initialize the Diff filter. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| x : str | ||
| Name of the first variable. | ||
| y : str | ||
| Name of the second variable. | ||
| diff : str | ||
| Name of the difference variable. | ||
| """ | ||
|
|
||
| self.x = x | ||
| self.y = y | ||
| self.diff = diff | ||
| self.return_inputs = return_inputs | ||
|
|
||
| def forward_transform(self, x: ekd.Field, y: ekd.Field) -> ekd.Field: | ||
| """Compute the difference between two fields (X - Y). | ||
|
|
||
| Parameters | ||
| ---------- | ||
| x : ekd.Field | ||
| The first variable. | ||
| y : ekd.Field | ||
| The second variable. | ||
|
|
||
| Returns | ||
| ------- | ||
| ekd.Field | ||
| The difference field. | ||
| """ | ||
|
|
||
| diff = x.to_numpy() - y.to_numpy() | ||
| yield self.new_field_from_numpy(diff, template=x, param=self.diff) | ||
|
|
||
| def backward(self, diff: ekd.FieldList) -> ekd.FieldList: | ||
| raise NotImplementedError("Difference filter is not reversible") | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.