Skip to content

remove the reader window session redux state synchronisation between main/renderer process to replace it with read/write disk instead and fix readingFinished#3455

Closed
panaC wants to merge 2 commits intodevelopfrom
remove-reader-reduxstate-sync
Closed

remove the reader window session redux state synchronisation between main/renderer process to replace it with read/write disk instead and fix readingFinished#3455
panaC wants to merge 2 commits intodevelopfrom
remove-reader-reduxstate-sync

Conversation

@panaC
Copy link
Copy Markdown
Member

@panaC panaC commented Mar 19, 2026

Remove the redux state synchronization between the reader and the main process. Instead, persist only the specific actions that need to be saved (e.g., config or locator), favoring atomic updates rather than syncing the entire state.

The reader session state is currently initialized when a new reader is created but is never updated with the latest reader Redux state. It replace this behavior with a read/write mechanism to disk instead.

A strict Redux state hydration is now sent to the reader window, with no inheritance from the main Redux state.

The reader publication identifier is added to the sender key in the action object produced by the sync function between the renderer and the main process. This removes the need to query the reader win session state to determine the pubId.

Add an inversion of control for closing reader from main process in the readingFinished issues with the reader sync and the reader closing that should be delayed. Fixes #3446

@panaC panaC self-assigned this Mar 19, 2026
@panaC panaC changed the title remove the reader window session redux state synchronisation between main/renderer process to replace it with read/write disk instead remove the reader window session redux state synchronisation between main/renderer process to replace it with read/write disk instead and fix readingFinished Mar 19, 2026
@panaC panaC closed this Mar 23, 2026
@panaC panaC deleted the remove-reader-reduxstate-sync branch March 24, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reader readingFinished action not working from the reader AND not persisted on disk

1 participant