Conversation
This was referenced Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the redux state synchronization between the reader and the main process. Instead, persist only the specific actions that need to be saved (e.g., config or locator), favoring atomic updates rather than syncing the entire state.
The reader session state is currently initialized when a new reader is created but is never updated with the latest reader Redux state. It replace this behavior with a read/write mechanism to disk instead.
A strict Redux state hydration is now sent to the reader window, with no inheritance from the main Redux state.
The reader publication identifier is added to the sender key in the action object produced by the sync function between the renderer and the main process. This removes the need to query the reader win session state to determine the pubId.
Add an inversion of control for closing reader from main process in the readingFinished issues with the reader sync and the reader closing that should be delayed. Fixes #3446