Conversation
…click-delay Make button multi-click delay configurable
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 273a258fb9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| then: | ||
| - delay: | ||
| milliseconds: ${BUTTON_MULTI_CLICK_DELAY} | ||
| - delay: !lambda return nr_button_multi_click_delay->state; |
There was a problem hiding this comment.
Restore fallback for undefined multi-click delay
This line now references nr_button_multi_click_delay, but that ID is only defined in TX-Ultimate-Easy-ESPHome_hw_touch.yaml; TX-Ultimate-Easy-ESPHome_hw_buttons.yaml itself does not declare it. As a result, users who include the hardware buttons package without the touch package will hit a compile/config error (“id not found”) and the build will fail. Consider defining the number entity in this file (or a shared common package), or fall back to the ${BUTTON_MULTI_CLICK_DELAY} substitution when the entity doesn’t exist.
Useful? React with 👍 / 👎.
No description provided.