Skip to content

Latest#149

Merged
edwardtfn merged 5 commits intov9999.99.9from
main
Jan 18, 2026
Merged

Latest#149
edwardtfn merged 5 commits intov9999.99.9from
main

Conversation

@edwardtfn
Copy link
Owner

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 18, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch main

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@edwardtfn edwardtfn merged commit 73f178a into v9999.99.9 Jan 18, 2026
10 checks passed
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 273a258fb9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

then:
- delay:
milliseconds: ${BUTTON_MULTI_CLICK_DELAY}
- delay: !lambda return nr_button_multi_click_delay->state;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore fallback for undefined multi-click delay

This line now references nr_button_multi_click_delay, but that ID is only defined in TX-Ultimate-Easy-ESPHome_hw_touch.yaml; TX-Ultimate-Easy-ESPHome_hw_buttons.yaml itself does not declare it. As a result, users who include the hardware buttons package without the touch package will hit a compile/config error (“id not found”) and the build will fail. Consider defining the number entity in this file (or a shared common package), or fall back to the ${BUTTON_MULTI_CLICK_DELAY} substitution when the entity doesn’t exist.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants