Skip to content

Latest #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edwardtfn merged 5 commits into from
Jan 18, 2026
Merged

Latest #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4408a3b
Make button multi-click delay configurable
jakub-k-dev Jan 16, 2026
52a75b4
Lint
edwardtfn Jan 18, 2026
b667403
Merge branch 'main' into pr/147
edwardtfn Jan 18, 2026
271175e
Merge pull request #147 from jakub-k-dev/feature/configurable-button-…
edwardtfn Jan 18, 2026
273a258
Bump version to 2026.1.2 [skip-versioning]
actions-user Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ESPHome/TX-Ultimate-Easy-ESPHome_hw_buttons.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,7 @@ script:
button: uint8_t
click_count: uint8_t
then:
- delay:
milliseconds: ${BUTTON_MULTI_CLICK_DELAY}
- delay: !lambda return nr_button_multi_click_delay->state;
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore fallback for undefined multi-click delay

This line now references nr_button_multi_click_delay, but that ID is only defined in TX-Ultimate-Easy-ESPHome_hw_touch.yaml; TX-Ultimate-Easy-ESPHome_hw_buttons.yaml itself does not declare it. As a result, users who include the hardware buttons package without the touch package will hit a compile/config error (“id not found”) and the build will fail. Consider defining the number entity in this file (or a shared common package), or fall back to the ${BUTTON_MULTI_CLICK_DELAY} substitution when the entity doesn’t exist.

Useful? React with 👍 / 👎.

- lambda: |-
std::string event_name;
if (click_count == 1) event_name = "click";
Expand Down
16 changes: 16 additions & 0 deletions ESPHome/TX-Ultimate-Easy-ESPHome_hw_touch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
---
substitutions:
TOUCH_POSITION_MAX_VALUE: '10' # Maximum touch position value returned by the touch pad via uart
BUTTON_MULTI_CLICK_DELAY: '250' # The time to wait for another click, in msec

ID_SWIPE_LEFT_TEXT: "left"
ID_SWIPE_RIGHT_TEXT: "right"
Expand Down Expand Up @@ -230,6 +231,21 @@ number:
optimistic: true
restore_value: true

- id: nr_button_multi_click_delay
name: Button multi-click delay
icon: mdi:timer-outline
unit_of_measurement: ms
mode: box
internal: false
entity_category: config
platform: template
min_value: 0
max_value: 2000
step: 10
initial_value: ${BUTTON_MULTI_CLICK_DELAY}
optimistic: true
restore_value: true

script:
- id: !extend boot_initialize
then:
Expand Down
2 changes: 1 addition & 1 deletion versioning/VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2026.1.1
2026.1.2
2 changes: 1 addition & 1 deletion versioning/VERSION_YAML
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
version: 2026.1.1
version: 2026.1.2