Skip to content

Conversation

@Pusty
Copy link
Contributor

@Pusty Pusty commented Dec 20, 2024

Fixes #244, As suggested this fixes the problem of hash collisions (and specifically the hash(-1) == hash(-2) case).
Benchmark shows no change for either the original suggested change or the slightly more optimized one, but it seems reasonable to use it in the improved form.
There is also a change to the pyproject.toml - adding a version, which seemed required to get the CI to work for me

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 20, 2024

CodSpeed Performance Report

Merging #245 will not alter performance

Comparing Pusty:calldeclfix (c0a1565) with main (8b17580)

Summary

✅ 8 untouched benchmarks

@saulshanabrook saulshanabrook merged commit 3829d69 into egraphs-good:main Dec 20, 2024
10 checks passed
@saulshanabrook
Copy link
Member

Thank you for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with CallDecl __eq__

2 participants