Skip to content

CallDecl __eq__ Fix #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 20, 2024
Merged

CallDecl __eq__ Fix #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c107e7b
Added required version field to pyproject.toml
Pusty Dec 20, 2024
52e85e9
Undoing optimization CallDecl __eq__
Pusty Dec 20, 2024
5655c2f
Copied wrong line
Pusty Dec 20, 2024
61ee2ea
Partial Optimization
Pusty Dec 20, 2024
49e0c01
Update pyproject.toml
Pusty Dec 20, 2024
c0a1565
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ build-backend = "maturin"
name = "egglog"
description = "e-graphs in Python built around the the egglog rust library"
readme = "README.md"
dynamic = ["version"]
license = { text = "MIT" }
requires-python = ">=3.10"
classifiers = [
Expand Down
8 changes: 7 additions & 1 deletion python/egglog/declarations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,13 @@ def __eq__(self, other: object) -> bool:
# Override eq to use cached hash for perf
if not isinstance(other, CallDecl):
return False
return hash(self) == hash(other)
if hash(self) != hash(other):
return False
return (
self.callable == other.callable
and self.args == other.args
and self.bound_tp_params == other.bound_tp_params
)


@dataclass(frozen=True)
Expand Down
Loading