You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following the discussion in #88 , this PR introduces edm4eic::Jet. This type, inspired by the fastjet::PseudoJet, aims to represent jets in our data model in a more adequate way than edm4eic::ReconstructedParticle.
Note these 3 design choices:
Only edm4eic::ReconstructedParticle are allowed as constituents, which places jet reconstruction in the final stages of reconstruction,
No substructure quantities are represented in the type, which defers them to analyses,
And the one-to-many relation jets allows for either the indication of/connection to sub-jets, seed jets (which may be deployed in background-subtraction algorithms), or background jets (e.g. off-axis cones).
Hi all, following up on the 02.10.2026 Key4hep Discussion, I just pushed a change to remove the one-to-many relation to other edm4eic::Jets. After some thought, I definitely agree with the suggestion! If need be, we can always use links to connect one jet to another!
As for generalizing to edm4hep, I think we need some more time to mull over the best approach. How would you feel about the following strategy, @tmadlener ?
If no more feedback, we merge the type as-is into EDM4eic,
We use the type in the EIC stack for a bit to get a better feel for potential use cases,
And then we start working out what a more general approach would be based on that data.
Apologies for the delayed response. The strategy sounds perfectly fine for me (at least from the EDM4hep side). I guess we can also start an upstream PR from the current state and keep / start discussing there.
Apologies for the delayed response. The strategy sounds perfectly fine for me (at least from the EDM4hep side). I guess we can also start an upstream PR from the current state and keep / start discussing there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Following the discussion in #88 , this PR introduces
edm4eic::Jet. This type, inspired by thefastjet::PseudoJet, aims to represent jets in our data model in a more adequate way thanedm4eic::ReconstructedParticle.Note these 3 design choices:
edm4eic::ReconstructedParticleare allowed as constituents, which places jet reconstruction in the final stages of reconstruction,jetsallows for either the indication of/connection to sub-jets, seed jets (which may be deployed in background-subtraction algorithms), or background jets (e.g. off-axis cones).What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.