Skip to content

Add edm4eic::Jet #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add edm4eic::Jet #118

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e57a067
Add jet type
ruse-traveler Jul 9, 2025
c280437
Fix typos in docstrings
ruse-traveler Jul 14, 2025
d2ca0af
Merge branch 'main' into add-jet-type
ruse-traveler Nov 17, 2025
05accd3
Add type field
ruse-traveler Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions edm4eic.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,6 +539,23 @@ datatypes:
OneToManyRelations:
- edm4eic::ReconstructedParticle hadrons // Reconstructed hadrons used in calculation

## ==========================================================================
## Jets
## ==========================================================================

edm4eic::Jet:
Description: "A reconstructed jet, inspired by the FastJet PseudoJet"
Author: "D. Anderson"
Members:
- uint32_t type // type of jet (0 - kt, 1 - C/A, 2 - anti-kt, ...)
Copy link
Contributor

@tmadlener tmadlener Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose to either

  • define static const values that define each type, or
  • clearly specify where the information of how to interpret this field can be obtained.

For the second part we have defined labels in EDM4hep that define the name of some metadata (Frame) parameter under which this information can be obtained, e.g.: https://github.com/key4hep/EDM4hep/blob/4d2242478347716d05b86c927fa6337764a5af62/edm4hep.yaml#L404

The labels are defined, here:
https://github.com/key4hep/EDM4hep/blob/4d2242478347716d05b86c927fa6337764a5af62/include/edm4hep/Constants.h#L25-L45

- float area // jet area
- float energy // jet energy [GeV]
- float backgroundEnergy // background energy density * area [GeV]
Copy link
Contributor

@tmadlener tmadlener Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(showing my ignorance here), I suppose the background energy density is rarely used, which is why you go for the product here instead?

- edm4hep::Vector3f momentum // jet 3-momentum [GeV]
OneToManyRelations:
- edm4eic::Jet jets // jets that have been combined to form this jet
- edm4eic::ReconstructedParticle constituents // constituents of this jet

## ==========================================================================
## Data-Montecarlo relations
## ==========================================================================
Expand Down