Fixed thickness calculation for sensitive surface #983
+10
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
I believe there is a minor bug in the calculation of the inner and outer thicknesses for the sensitive surface in
BarrelTrackerWithFrame_geo.cpp. When there are two sensitive compositions placed at the same z position, the thicknesses for the second are incorrect because of the order in which the calculation is done.To fix this, I moved the
thickness_so_farcalculation to before theif (x_comp.isSensitive()) {section, and changed the sign of+ x_comp.thickness() / 2.0when it is used to calculate the inner and outer thicknesses.Before the fix:
After the fix:
I hope this has fixed the issue.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?