Skip to content

Fixed thickness calculation for sensitive surface #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −9
Open

Fixed thickness calculation for sensitive surface #983

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
626ec71
Fixed thickness calculation for sensitive surface
Nov 10, 2025
63a8eed
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions src/BarrelTrackerWithFrame_geo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,12 +199,20 @@ static Ref_t create_BarrelTrackerWithFrame(Detector& description, xml_h e, Sensi
c_vol.setRegion(description, x_comp.regionStr());
c_vol.setLimitSet(description, x_comp.limitsStr());
c_vol.setVisAttributes(description, x_comp.visStr());
// Calculate thickness_so_far before setting sensitive surface so it can be used to calculate inner and outer thicknesses correctly
thickness_sum += x_comp.thickness();
thickness_so_far += x_comp.thickness();
// apply relative offsets in z-position used to stack components side-by-side
if (x_pos) {
thickness_sum += x_pos.z(0);
thickness_so_far += x_pos.z(0);
}
if (x_comp.isSensitive()) {
pv.addPhysVolID("sensor", sensor_number++);
c_vol.setSensitiveDetector(sens);
sensitives[m_nam].push_back(pv);
module_thicknesses[m_nam] = {thickness_so_far + x_comp.thickness() / 2.0,
total_thickness - thickness_so_far - x_comp.thickness() / 2.0};
module_thicknesses[m_nam] = {thickness_so_far - x_comp.thickness() / 2.0,
total_thickness - thickness_so_far + x_comp.thickness() / 2.0};

// -------- create a measurement plane for the tracking surface attched to the sensitive volume -----
Vector3D u(-1., 0., 0.);
Expand All @@ -227,13 +235,6 @@ static Ref_t create_BarrelTrackerWithFrame(Detector& description, xml_h e, Sensi

//--------------------------------------------
}
thickness_sum += x_comp.thickness();
thickness_so_far += x_comp.thickness();
// apply relative offsets in z-position used to stack components side-by-side
if (x_pos) {
thickness_sum += x_pos.z(0);
thickness_so_far += x_pos.z(0);
}
}
}

Expand Down
Loading