azure-eventhub v2: Fix processingTime input metric#40547
Closed
zmoog wants to merge 1 commit intoelastic:mainfrom
Closed
azure-eventhub v2: Fix processingTime input metric#40547zmoog wants to merge 1 commit intoelastic:mainfrom
zmoog wants to merge 1 commit intoelastic:mainfrom
Conversation
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
kaiyan-sheng
approved these changes
Aug 20, 2024
Contributor
|
|
Update the processingTime input metric only once after the for loop using the time since processingStartTime. Before this change, by updating processingStartTime inside the loop we ended up counting time multiple times.
051590e to
48cf35f
Compare
6 tasks
Contributor
Author
|
Superseded by #49864 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Update the
processingTimeinput metric only once after the for loop using the time sinceprocessingStartTime.Before this change, by updating
processingStartTimeinside the loop we ended up counting time multiple times.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs