azure-eventhub v2: fix processingTime input metric by zmoog · Pull Request #49864 · elastic/beats

zmoog · 2026-04-01T20:14:41Z

Proposed commit message

Move the processingTime metric update outside the loop in processReceivedEvents so it is recorded once per batch instead of once per event.

Before this change, processingStartTime was set once before the loop but processingTime.Update() was called on every iteration. Since time.Since(processingStartTime) grows with each iteration, the histogram received N cumulative samples (~T, ~2T, ~3T, ...) instead of a single sample with the total batch processing time. This inflated the histogram sample count and skewed percentiles.

Revives #40547 with an added regression test.

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Run the new unit test:

go test ./x-pack/filebeat/input/azureeventhub/ -run TestProcessReceivedEventsUpdatesProcessingTimeOnce -v

The test sends 3 events through processReceivedEvents and asserts that processingTime is updated exactly once (after the loop), not 3 times (once per event).

Related issues

Supersedes azure-eventhub v2: Fix processingTime input metric #40547

🤖 Generated with Claude Code

Move the processingTime metric update outside the loop in processReceivedEvents so it is recorded once per batch instead of once per event. Previously, because processingStartTime was set before the loop and never reset, each iteration recorded a cumulative duration: ~T, ~2T, ~3T, etc. This inflated the histogram sample count and skewed percentiles. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions · 2026-04-01T20:14:54Z

🤖 GitHub comments

Just comment with:

run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

coderabbitai · 2026-04-01T20:18:13Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 284e82c4-727b-404c-953f-4e8d4c380220

📥 Commits

Reviewing files that changed from the base of the PR and between e4d1bf5 and da1a488.

📒 Files selected for processing (1)

x-pack/filebeat/input/azureeventhub/v2_input_test.go

📝 Walkthrough

Walkthrough

The update moves the processingTime metric update from inside the per-event processing loop to run once after all events in a received batch are processed, changing the metric from per-event to per-batch updates. A unit test was added to assert that processing time is recorded exactly once per batch while processed message counts reflect all events. A changelog fragment documenting the bug fix for the azureeventhub input processing time metric was also added.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

🛠️ Update Documentation: Commit on current branch
🛠️ Update Documentation: Create PR

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

mergify · 2026-04-01T21:18:00Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @zmoog? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
backport-active-all is the label that automatically backports to all active branches.
backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

constanca-m

Good find

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

elasticmachine · 2026-04-09T14:52:34Z

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

github-actions · 2026-04-09T14:53:41Z

@Mergifyio backport 8.19 9.3 9.4

mergify · 2026-04-09T15:53:24Z

backport 8.19 9.3 9.4

✅ Backports have been created

Details

#50043 [8.19](backport #49864) azure-eventhub v2: fix processingTime input metric has been created for branch 8.19
#50044 [9.3](backport #49864) azure-eventhub v2: fix processingTime input metric has been created for branch 9.3
#50045 [9.4](backport #49864) azure-eventhub v2: fix processingTime input metric has been created for branch 9.4

* azure-eventhub v2: fix processingTime input metric Move the processingTime metric update outside the loop in processReceivedEvents so it is recorded once per batch instead of once per event. Previously, because processingStartTime was set before the loop and never reset, each iteration recorded a cumulative duration: ~T, ~2T, ~3T, etc. This inflated the histogram sample count and skewed percentiles. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Update changelog * Fix forbidigo lint: replace logp.NewLogger with logp.L() in tests Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Switch to logptest --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> (cherry picked from commit 19da895)

zmoog requested a review from a team as a code owner April 1, 2026 20:14

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 1, 2026

Update changelog

32e21ed

zmoog mentioned this pull request Apr 1, 2026

azure-eventhub v2: Fix processingTime input metric #40547

Closed

6 tasks

mergify bot assigned zmoog Apr 1, 2026

constanca-m approved these changes Apr 2, 2026

View reviewed changes

Fix forbidigo lint: replace logp.NewLogger with logp.L() in tests

e4d1bf5

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

tetianakravchenko approved these changes Apr 2, 2026

View reviewed changes

Switch to logptest

da1a488

github-actions bot mentioned this pull request Apr 2, 2026

[Release] Update test environments for 9.3.4 #49906

Open

mykola-elastic approved these changes Apr 7, 2026

View reviewed changes

zmoog added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team label Apr 9, 2026

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 9, 2026

zmoog added needs_team Indicates that the issue/PR needs a Team:* label bugfix labels Apr 9, 2026

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 9, 2026

zmoog added input:azure-eventhub backport-active-all Automated backport with mergify to all the active branches labels Apr 9, 2026

zmoog merged commit 19da895 into elastic:main Apr 9, 2026
44 checks passed

mergify bot mentioned this pull request Apr 9, 2026

[8.19](backport #49864) azure-eventhub v2: fix processingTime input metric #50043

Open

6 tasks

mergify bot mentioned this pull request Apr 9, 2026

[9.3](backport #49864) azure-eventhub v2: fix processingTime input metric #50044

Open

6 tasks

mergify bot mentioned this pull request Apr 9, 2026

[9.4](backport #49864) azure-eventhub v2: fix processingTime input metric #50045

Open

6 tasks

zmoog mentioned this pull request Apr 10, 2026

fix: update azeventhubs v2 import in v2_input_test.go #50051

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

azure-eventhub v2: fix processingTime input metric#49864

azure-eventhub v2: fix processingTime input metric#49864
zmoog merged 4 commits intoelastic:mainfrom
zmoog:fix-processing-time-metric

zmoog commented Apr 1, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

coderabbitai bot commented Apr 1, 2026 •

edited

Loading

Walkthrough

Uh oh!

mergify bot commented Apr 1, 2026

Uh oh!

constanca-m left a comment

Uh oh!

elasticmachine commented Apr 9, 2026

Uh oh!

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

mergify bot commented Apr 9, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

zmoog commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed commit message

Checklist

How to test this PR locally

Related issues

Uh oh!

github-actions bot commented Apr 1, 2026

🤖 GitHub comments

Uh oh!

coderabbitai bot commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

mergify bot commented Apr 1, 2026

Uh oh!

constanca-m left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Apr 9, 2026

Uh oh!

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

mergify bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zmoog commented Apr 1, 2026 •

edited

Loading

coderabbitai bot commented Apr 1, 2026 •

edited

Loading

mergify bot commented Apr 9, 2026 •

edited

Loading