Skip to content

[9.4](backport #49583) filebeat: auto-build test binary in Go integration tests via TestMain#50113

Merged
AndersonQ merged 1 commit into9.4from
mergify/bp/9.4/pr-49583
Apr 14, 2026
Merged

[9.4](backport #49583) filebeat: auto-build test binary in Go integration tests via TestMain#50113
AndersonQ merged 1 commit into9.4from
mergify/bp/9.4/pr-49583

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Apr 14, 2026

Proposed commit message

filebeat: auto-build test binary in Go integration tests via TestMain

Move the filebeat.test binary build step from the mage targets into TestMain so that `go test -tags integration` works without requiring a prior `mage buildSystemTestBinary`. This removes a manual prerequisite that tripped up developers running integration tests locally.

  - Add BuildSystemTestBinary helper to libbeat/tests/integration/framework.go
  - Add TestMain in filebeat and x-pack/filebeat integration test packages
  - Remove BuildSystemTestBinary from mage GoIntegTest/GoFIPSOnlyIntegTest
  - Python integration tests are unchanged (they still use devtools directly)

Assisted by Claude

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool.

Disruptive User Impact

  • N/A

How to test this PR locally

  • Ensure there is not "SystemTestBinary", run any filebeat Go integration test, they'll works

Related issues

…#49583)

* filebeat: auto-build test binary in Go integration tests via TestMain

Move the filebeat.test binary build step from the mage targets into
TestMain so that `go test -tags integration` works without requiring
a prior `mage buildSystemTestBinary`. This removes a manual prerequisite
that tripped up developers running integration tests locally.

  - Add BuildSystemTestBinary helper to libbeat/tests/integration/framework.go
  - Add TestMain in filebeat and x-pack/filebeat integration test packages
  - Remove BuildSystemTestBinary from mage GoIntegTest/GoFIPSOnlyIntegTest
  - Python integration tests are unchanged (they still use devtools directly)

Assisted by Claude

(cherry picked from commit 323f731)
@mergify mergify bot requested a review from a team as a code owner April 14, 2026 07:49
@mergify mergify bot added the backport label Apr 14, 2026
@mergify mergify bot requested a review from a team as a code owner April 14, 2026 07:49
@mergify mergify bot requested review from VihasMakwana and orestisfl and removed request for a team April 14, 2026 07:49
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@github-actions github-actions bot added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team skip-changelog labels Apr 14, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 14, 2026
@AndersonQ AndersonQ merged commit 65b7738 into 9.4 Apr 14, 2026
211 of 212 checks passed
@AndersonQ AndersonQ deleted the mergify/bp/9.4/pr-49583 branch April 14, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants