Adding an allowlist for EPR links for the image directive #1651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
requested changes
Jul 29, 2025
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
Quick nitpicks while on my phone.
Mpdreamz
approved these changes
Jul 29, 2025
Member
|
I will force merge this, because the smoke tests and unit tests are successful. the failing preview build is related to permissions. |
reakaleek
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an allowlist to the image directive URI check for links to the elastic package registry so that we can easily utilize integration images in the docs
Relates https://github.com/elastic/integration-docs/pull/827
I manually verified this by checking that changing the line to
:::{image} https://epr.elastic.co/package/system_audit/1.11.0/img/system-audit-package-dashboard.pngand saw no build warnings.