Skip to content

Adding an allowlist for EPR links for the image directive #1651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2025
Merged

Adding an allowlist for EPR links for the image directive #1651

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d724d1a
adding an allowlist for epr links
kgeller Jul 29, 2025
13080af
review feedback
kgeller Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Elastic.Markdown/Myst/Directives/Image/ImageBlock.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ public class ImageBlock(DirectiveBlockParser parser, ParserContext context)

public string? Label { get; private set; }

private static readonly HashSet<string> AllowedUriHosts = ["epr.elastic.co"];

public override void FinalizeAndValidate(ParserContext context)
{
Label = Prop("label", "name");
Expand Down Expand Up @@ -98,7 +100,9 @@ private void ExtractImageUrl(ParserContext context)

if (Uri.TryCreate(imageUrl, UriKind.Absolute, out var uri) && uri.Scheme.StartsWith("http"))
{
this.EmitWarning($"{Directive} is using an external URI: {uri} ");
if (!AllowedUriHosts.Contains(uri.Host))
this.EmitWarning($"{Directive} is using an external URI: {uri} ");

Found = true;
ImageUrl = imageUrl;
return;
Expand Down
Loading