Improve versioning system inference #2070
Open
+22
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
requested changes
Oct 18, 2025
| var currentBaseVersion = legacyPages is { Count: > 0 } | ||
| ? $"{legacyPages.ElementAt(0).Product.VersioningSystem?.Base.Major}.{legacyPages.ElementAt(0).Product.VersioningSystem?.Base.Minor}+" | ||
| : $"{DocumentationSet.Context.VersionsConfiguration.VersioningSystems[VersioningSystemId.Stack].Base.Major}.{DocumentationSet.Context.VersionsConfiguration.VersioningSystems[VersioningSystemId.Stack].Base.Minor}+"; | ||
| // Acquiring the versioning system for the current page: |
There was a problem hiding this comment.
Move this to an isolated place like LegacyPageService or something new
| VersioningSystem pageVersioning = null!; | ||
| if (legacyPages is not null && legacyPages.Count > 0) | ||
| pageVersioning = legacyPages.ElementAt(0).Product.VersioningSystem!; | ||
| else if (DocumentationSet.Context.ProductsConfiguration.Products.TryGetValue(DocumentationSet.Name, out var belonging)) |
There was a problem hiding this comment.
Lets use Git.RepositoryName explicitly over DocumentationSet.Name
| pageVersioning = legacyPages.ElementAt(0).Product.VersioningSystem!; | ||
| else if (DocumentationSet.Context.ProductsConfiguration.Products.TryGetValue(DocumentationSet.Name, out var belonging)) | ||
| pageVersioning = belonging.VersioningSystem!; | ||
| else if (DocumentationSet.Configuration.TableOfContents.FirstOrDefault(t => t is TocReference tRef && !tRef.Source.LocalPath.Equals("/")) is TocReference tocRef) |
There was a problem hiding this comment.
This is clever I wonder if its too clever though? What are the cases where this is needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2018
Improves inference of the versioning system in situations where pages have no legacy URL mappings, or have different repository names from their current reference designation.