Skip to content

Conversation

eedugon
Copy link
Contributor

@eedugon eedugon commented Apr 3, 2025

Secure settings page has been updated.
Major changes.

@eedugon eedugon changed the title secure settings preliminary changes secure settings refinement Apr 3, 2025
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you mean about the es/kibana weirdness, but I think it's ok because fixing it would require quite a bit of restructuring. consider, however, logging an issue for this because the kib command line tools doc is incomplete.

consider linking up from the ECK topic to the secure your settings topic and explain that that page contains basic info about secure settings

Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

furthermore: I think we'd like to reduce the # of API examples we have free-floating over here (and instead have API examples as close to the procedure as possible), so I think at some point it would be nice to have the API instructions integrated into this doc. I know you just changed the mapping but just wanted to make you aware of what I expect the longer-term strategy is

@eedugon eedugon requested a review from shainaraskas April 4, 2025 10:09
@eedugon
Copy link
Contributor Author

eedugon commented Apr 4, 2025

@shainaraskas : I think i've got it now :)

Please review:

  • The only opened conversation (it's about the encryption at rest and the serverless row).
  • The new headings within the tabs -> They make the OTP to look a bit weird but probably it's not a big deal.

Thanks a lot for your help as always!

@eedugon eedugon enabled auto-merge (squash) April 4, 2025 15:51
@eedugon eedugon merged commit 5fccbfd into main Apr 4, 2025
3 of 4 checks passed
@eedugon eedugon deleted the secure_settings branch April 4, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants