-
Notifications
You must be signed in to change notification settings - Fork 184
[Private preview] Add docs for Cloud Connect + AutoOps for self-managed clusters #2287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Private preview] Add docs for Cloud Connect + AutoOps for self-managed clusters #2287
Conversation
arnonst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
deploy-manage/monitor/autoops/cc-connect-self-managed-to-autoops.md
Outdated
Show resolved
Hide resolved
deploy-manage/monitor/autoops/cc-connect-self-managed-to-autoops.md
Outdated
Show resolved
Hide resolved
deploy-manage/monitor/autoops/cc-connect-self-managed-to-autoops.md
Outdated
Show resolved
Hide resolved
deploy-manage/monitor/autoops/cc-connect-self-managed-to-autoops.md
Outdated
Show resolved
Hide resolved
deploy-manage/monitor/autoops/cc-connect-self-managed-to-autoops.md
Outdated
Show resolved
Hide resolved
deploy-manage/monitor/autoops/cc-connect-self-managed-to-autoops.md
Outdated
Show resolved
Hide resolved
deploy-manage/monitor/autoops/cc-connect-self-managed-to-autoops.md
Outdated
Show resolved
Hide resolved
deploy-manage/monitor/autoops/cc-connect-self-managed-to-autoops.md
Outdated
Show resolved
Hide resolved
shainaraskas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
came in to add some comments on your applies_to tagging and then just finished a full review sorry for the noise
deploy-manage/monitor/autoops/cc-cloud-connect-autoops-troubleshooting.md
Outdated
Show resolved
Hide resolved
deploy-manage/monitor/autoops/cc-cloud-connect-autoops-troubleshooting.md
Outdated
Show resolved
Hide resolved
deploy-manage/monitor/autoops/cc-cloud-connect-autoops-troubleshooting.md
Outdated
Show resolved
Hide resolved
deploy-manage/monitor/autoops/cc-cloud-connect-autoops-troubleshooting.md
Outdated
Show resolved
Hide resolved
|
Very nice work @wajihaparvez! |
deploy-manage/monitor/autoops/cc-connect-self-managed-to-autoops.md
Outdated
Show resolved
Hide resolved
|
Thanks all for the in-depth reviews! |
|
Waiting for clarification from @arnonst on the new request to add info about creating a role with dev tools + some error message questions Edit: I've pushed my changes. I've commented out the dev tools role section until I can get some more clarity. Edit 2: I've updated the pages with info about creating a role with dev tools + more clarification about authentication methods and privileges. Ready to publish. |
kilfoyle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🦖
Nice work @wajihaparvez!
The docs added in this PR are meant for private preview, so they are hidden from the ToC.
I've added all the docs at the same level for now, because hidden files can't have child pages. We can fix that and decide on exact positioning for GA. It doesn't matter right now because customers won't be able to navigate to them from the ToC anyway.
To avoid any confusion about the structure, I've added a section overview on the AutoOps for self-managed clusters page with links to all the other pages.
Closes: https://github.com/elastic/docs-content-internal/issues/16 and https://github.com/elastic/docs-content-internal/issues/12