-
Notifications
You must be signed in to change notification settings - Fork 181
Expand filebased user for recovering security #2489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 @elastic/admin-docs , I did try to figure out the links myself from Brandon's earlier guidance but apparently could use more help, sorry 🙂🙏 |
deploy-manage/users-roles/cluster-or-deployment-auth/file-based.md
Outdated
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/file-based.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the information about recovering security does not necessarily belong in this doc. while the file might need to be refactored, introducing this information and the role information blows up the scope of the page. the recovery use case might work better as a standalone tutorial.
shainaraskas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment
|
Thanks, @shainaraskas ! And apologies for delay on my side. I have ported into a troubleshooting guide (with some minor edits left on first page). 🙏 |
deploy-manage/users-roles/cluster-or-deployment-auth/file-based.md
Outdated
Show resolved
Hide resolved
shainaraskas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally looks really good. I've edited the recovery tutorial a little for grammar and flow
questions:
- is the person always going to need the allow_restricted_indices permission? should we guide them when they should/should not use it?
- can we give them next steps, e.g. testing of this user, recovery tasks ...?
let me know how badly I butchered things with my edits
shainaraskas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link fix suggestions
shainaraskas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if dev is happy we're good to merge
tvernum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good and is a very welcome addition. I had a few minor suggestions to make the wording more accurately reflect the how the underlying features work.
deploy-manage/users-roles/cluster-or-deployment-auth/file-based.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Tim Vernum <[email protected]>
Refactors filebased realm page for clarity & expands examples to include file-based
role.ymldefinitions needed to recovering security.Relates #2479