Skip to content

Conversation

ketkee-aryamane
Copy link
Contributor

Adjusting content to accommodate feedback from @kderusso
Feedback was provided in https://github.com/elastic/docs-content/pull/2252/files

Also added product id in frontmatter to ensure it helps web team to implement internal search for the page correctly.

@ketkee-aryamane ketkee-aryamane requested a review from a team as a code owner August 20, 2025 12:50
Copy link

github-actions bot commented Aug 20, 2025

🔍 Preview links for changed docs

Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes! One non-blocking suggestion, that I don't feel strongly about.

@leemthompo leemthompo changed the title correct content per devs feedback Update query rules UI page Aug 20, 2025
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @kderusso's happy, I'm happy :)

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Left a few minor suggestions for your consideration 🚀

@ketkee-aryamane
Copy link
Contributor Author

Nice work! Left a few minor suggestions for your consideration 🚀

Thanks for all your suggestions @benironside.

@ketkee-aryamane ketkee-aryamane merged commit 8726b2e into main Aug 21, 2025
7 checks passed
@ketkee-aryamane ketkee-aryamane deleted the refine-query-rules-ui-after-dev-feedback branch August 21, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants