Skip to content

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented Sep 9, 2025

A few updates to the DLM tutorials, corresponding to Edu's feedback in https://github.com/elastic/docs-content-internal/issues/190

@kilfoyle kilfoyle marked this pull request as ready for review September 10, 2025 17:38
@kilfoyle kilfoyle requested a review from a team as a code owner September 10, 2025 17:38
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with the content, but LGTM!

Copy link
Contributor

@yetanothertw yetanothertw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left one comment which I'm not sure about. Maybe check with Edu just to be on the safe side?

}
```

1. In this case the index template will be applied to a data stream named `my-data-stream-test`. You can optionally use a wildcard (`*`) in the index pattern to match all data streams created (either manually or using a an indexing request) that have a name matching the specified pattern.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo

Suggested change
1. In this case the index template will be applied to a data stream named `my-data-stream-test`. You can optionally use a wildcard (`*`) in the index pattern to match all data streams created (either manually or using a an indexing request) that have a name matching the specified pattern.
1. In this case the index template will be applied to a data stream named `my-data-stream-test`. You can optionally use a wildcard (`*`) in the index pattern to match all data streams created (either manually or using an indexing request) that have a name matching the specified pattern.

It's interesting that I actually interpreted Edu's feedback on this differently. I think he was okay with the API example (for creating the index template) using the ["my-data-stream*"] index pattern, and suggesting we changed the index name in the Create a data stream section to my-data-stream-test and then explain that this name works because of the wildcard used in the index template.
I thought it's preferable to use the wildcard in the template, because it would make the template more "universal" (broader scope of use).

Wdyt? Does any of this make sense? (I could also be totally wrong about this 🙈)

Copy link
Contributor Author

@kilfoyle kilfoyle Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yetanothertw Thanks for asking about this. I looked at the recording just now to confirm. It's at the "Create an index template" section (42:00) that Edu says the asterisk creates misunderstanding for users. Here's what he highlighted in the document while talking about that issue:

screen

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the typo. Thanks for catching that!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, it's very likely I misunderstood :)

Copy link
Contributor

@yetanothertw yetanothertw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kilfoyle kilfoyle merged commit 015b6a5 into elastic:main Sep 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants