-
Notifications
You must be signed in to change notification settings - Fork 163
Fix up data stream lifecycle tutorials #2884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not familiar with the content, but LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left one comment which I'm not sure about. Maybe check with Edu just to be on the safe side?
} | ||
``` | ||
|
||
1. In this case the index template will be applied to a data stream named `my-data-stream-test`. You can optionally use a wildcard (`*`) in the index pattern to match all data streams created (either manually or using a an indexing request) that have a name matching the specified pattern. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor typo
1. In this case the index template will be applied to a data stream named `my-data-stream-test`. You can optionally use a wildcard (`*`) in the index pattern to match all data streams created (either manually or using a an indexing request) that have a name matching the specified pattern. | |
1. In this case the index template will be applied to a data stream named `my-data-stream-test`. You can optionally use a wildcard (`*`) in the index pattern to match all data streams created (either manually or using an indexing request) that have a name matching the specified pattern. |
It's interesting that I actually interpreted Edu's feedback on this differently. I think he was okay with the API example (for creating the index template) using the ["my-data-stream*"]
index pattern, and suggesting we changed the index name in the Create a data stream section to my-data-stream-test
and then explain that this name works because of the wildcard used in the index template.
I thought it's preferable to use the wildcard in the template, because it would make the template more "universal" (broader scope of use).
Wdyt? Does any of this make sense? (I could also be totally wrong about this 🙈)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yetanothertw Thanks for asking about this. I looked at the recording just now to confirm. It's at the "Create an index template" section (42:00) that Edu says the asterisk creates misunderstanding for users. Here's what he highlighted in the document while talking about that issue:

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the typo. Thanks for catching that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, it's very likely I misunderstood :)
manage-data/lifecycle/data-stream/tutorial-create-data-stream-with-lifecycle.md
Outdated
Show resolved
Hide resolved
…with-lifecycle.md Co-authored-by: Vlada Chirmicci <[email protected]>
…with-lifecycle.md Co-authored-by: Vlada Chirmicci <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
A few updates to the DLM tutorials, corresponding to Edu's feedback in https://github.com/elastic/docs-content-internal/issues/190