-
Notifications
You must be signed in to change notification settings - Fork 163
Fix up data stream lifecycle tutorials #2884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
72659c6
Fix up data stream lifecycle tutorials
kilfoyle 8285904
fixup
kilfoyle 97d8810
Merge branch 'main' into 190/dsl-updates
kilfoyle 8dfd534
Remove nav title
kilfoyle e59747e
Update manage-data/lifecycle/data-stream/tutorial-create-data-stream-…
kilfoyle 2702843
Update manage-data/lifecycle/data-stream/tutorial-create-data-stream-…
kilfoyle e655738
Merge branch 'main' into 190/dsl-updates
kilfoyle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor typo
It's interesting that I actually interpreted Edu's feedback on this differently. I think he was okay with the API example (for creating the index template) using the
["my-data-stream*"]
index pattern, and suggesting we changed the index name in the Create a data stream section tomy-data-stream-test
and then explain that this name works because of the wildcard used in the index template.I thought it's preferable to use the wildcard in the template, because it would make the template more "universal" (broader scope of use).
Wdyt? Does any of this make sense? (I could also be totally wrong about this 🙈)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yetanothertw Thanks for asking about this. I looked at the recording just now to confirm. It's at the "Create an index template" section (42:00) that Edu says the asterisk creates misunderstanding for users. Here's what he highlighted in the document while talking about that issue:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the typo. Thanks for catching that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, it's very likely I misunderstood :)