-
Notifications
You must be signed in to change notification settings - Fork 155
Introducing Remote cluster filters in the docs #3034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!! Thanks a bunch for the great work
Co-authored-by: Alex Chalkias <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes are so clear and useful. I see why that remote cluster filter topic was so important for sure 👍
I think my remaining questions are mostly around the impacts of network security policies on self-managed and eck deployments. we should clearly state how those work.
Co-authored-by: shainaraskas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks really good. just a couple more small notes
Co-authored-by: shainaraskas <[email protected]>
@shainaraskas , thanks a lot for your help here! And for the use cases sub-section, I've left 2 options so we can choose and decide, with a table or without a table. Which one would you choose? I'm inclined to not use a table in this case, as I don't see much value on it, not even visually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good. couple of comments you can hopefully address then ship with :)
@shainaraskas , @alxchalkias , here you have the final content and statements around network security and remote clusters interactions.
The main changes of this PR are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eedugon your work here has been nothing short of outstanding! Thanks so much for the care and attention!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅 what an effort!!! lgtm!!!!!!!
This PR attempts to introduce and document the Remote Cluster filters that are available in ECH and ECE.
We had some small statements in certain remote clusters docs about needing this type of filter when network security was enabled in the remote cluster, but we didn't have the filter documented.
Changes:
Remote cluster filter is presented as a type of Private Connection policy in ECH and a type of filter rule set in ECE. This is located in Security -> Network Security docs, as filters belong there.
"Remote clusters and network security" information rehomed to the landing page of Remote Clusters, as it was duplicate in Remote Clusters > ECH and Remote Clusters > ECE docs --> If we prefer the previous approach we can use snippets and remove the content from the landing page, but let's start focusing on reviewing the content itself.
The notes of different use cases docs (ECE --> ECH, ECH --> ECH, etc) have been updated to reflect the reality, and to address https://github.com/elastic/docs-content-internal/issues/59.
For next PRs:
Preview links:
New filter type:
Landing page with the remote clusters and network security section:
Previous landing pages (small updates there due to the rehome):
Use case specific docs:
Network security landing page shows the new filter type in the list of available filters:
Closes #3034