-
Notifications
You must be signed in to change notification settings - Fork 152
ipv6 support for remote addresses added #3361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eedugon
wants to merge
5
commits into
main
Choose a base branch
from
rcs_ipv6_support_9.2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+96
−213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added extra fixes, as the "Elasticsearch API method" of both ECE -> self-managed and ECH -> self-managed docs were incorrect! |
* **API keys**: Use the port configured in the remote cluster interface of the remote cluster (defaults to `9443`). | ||
* **TLS Certificates**: Use the {{es}} transport port (defaults to `9300`). | ||
|
||
When using an IPv6 address ({applies_to}`stack: ga 9.2`), enclose it in square brackets followed by the port number. For example: `[2001:db8::1]:9443`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
When using an IPv6 address ({applies_to}`stack: ga 9.2`), enclose it in square brackets followed by the port number. For example: `[2001:db8::1]:9443`. | |
When using an IPv6 address, enclose it in square brackets followed by the port number. For example: `[2001:db8::1]:9443`. |
I don't think we need to repeat the applies to here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR describes that the Stack 9.2 supports IPv6 addresses when configuring a remote cluster within Kibana.
I don't want to highlight that much in our docs, as it doesn't feel necessary (we didn't even mention that we supported IPv4 at all, neither that IPv6 wasn't supported by Kibana (it was supported by Elasticsearch)).
Extra improvements:
Not updated (out of the scope of this PR)
Closes #3093