-
Notifications
You must be signed in to change notification settings - Fork 181
[Cloud Connect] Align Regions with ECH names #3588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This aligns the names to line up with the names listed for ECH. https://www.elastic.co/docs/reference/cloud/cloud-hosted/regions#ec_amazon_web_services_aws_regions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the region names in this snippet! 💟
This snippet is used in multiple locations, but there's one particular file where this is included, where I think the names of the other AWS regions listed (for serverless and ECH) also need to be updated, for consistency. This is the published version of this file.
This is a good place to check the correct names of all the regions.
If you'd rather I open a separate PR and update the names of the remaining regions, I'm happy to do it just let me know.
This is linked to #3588 and updates the names of the AWS regions to correspond to the full region names as listed [here](https://docs.aws.amazon.com/global-infrastructure/latest/regions/aws-regions.html).
yetanothertw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realised you're in a different timezone, so it was quicker to create another PR to update the rest of the regions.
Yours is approved! 🚀
This is linked to #3588 and updates the names of the AWS regions to correspond to the full region names as listed [here](https://docs.aws.amazon.com/global-infrastructure/latest/regions/aws-regions.html).
This is linked to elastic#3588 and updates the names of the AWS regions to correspond to the full region names as listed [here](https://docs.aws.amazon.com/global-infrastructure/latest/regions/aws-regions.html).
This aligns the names to line up with the names listed for ECH. https://www.elastic.co/docs/reference/cloud/cloud-hosted/regions#ec_amazon_web_services_aws_regions
This is linked to elastic#3588 and updates the names of the AWS regions to correspond to the full region names as listed [here](https://docs.aws.amazon.com/global-infrastructure/latest/regions/aws-regions.html).
This aligns the names to line up with the names listed for ECH. https://www.elastic.co/docs/reference/cloud/cloud-hosted/regions#ec_amazon_web_services_aws_regions
This aligns the names to line up with the names listed for ECH.
https://www.elastic.co/docs/reference/cloud/cloud-hosted/regions#ec_amazon_web_services_aws_regions