-
Notifications
You must be signed in to change notification settings - Fork 163
[Docs] Add instructions for creating an ES|QL chart without data views #906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wajihaparvez
merged 6 commits into
elastic:main
from
wajihaparvez:try-esql-without-data-views
Mar 25, 2025
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
dba58e2
Add instructions for creating ES|QL viz without data views
wajihaparvez dedd708
Remove trailing space
wajihaparvez 16d7f44
Merge branch 'main' into try-esql-without-data-views
wajihaparvez d731669
PR feedback
wajihaparvez 0459c89
add link
wajihaparvez 887a271
Merge branch 'main' into try-esql-without-data-views
wajihaparvez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this fits well here at the end of this section. This section explains how to add an ES|QL visualization from a dashboard, while this tip describes the "empty state" experience for when there's no dashboard yet in the Dashboards menu.
What we could do instead to avoid big changes, is to move this tip to under the first step, and say something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@florent-leborgne it is not exactly the empty experience if you dont have a dashboard. It is if you dont have a dashboard AND a dataview. So I think is important to mention the dataview here. This is the advantage of ESQL actually. You dont need dataviews
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I wasn't sure if not having a data view was also a prerequisite to show this UX. I edited my suggestion. (my main issue with this tip is where it's currently located, a bit out of place in the user narrative)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense, thanks for the suggestion! I've moved the tip below the first step and tweaked the wording a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanx both!