[test] split up k8s integration tests #8484

pkoutsovasilis · 2025-06-13T06:02:38Z

What does this PR do?

Split Kubernetes integration tests into a dedicated testing/integration/k8s package.
Removed the need for the kubernetes build tag; Kubernetes tests are now always compiled as part of the normal integration tag.
Introduced a TestMain entrypoint in the new package, enabling centralized setup logic.
Renamed mage targets to be consistent with other test oriented mage targets:
- integration:TestKubernetes (formerly integration:Kubernetes)
- integration:TestKubernetesMatrix (formerly integration:KubernetesMatrix)
- integration:TestKubernetesSingle (formerly integration:KubernetesSingle)
Updated all references in Buildkite pipeline and documentation accordingly.
Performed mechanical moves of existing Kubernetes test files into the new package (journald_test.go, kubernetes_agent_service_test.go, kubernetes_agent_standalone_test.go, otel_helm_test.go, and their respective testdata).

Why is it important?

This PR continues the ongoing effort of modularizing the ever-growing integration package as part of #8087. Specifically, it addresses the Kubernetes test split described in #8412.

Having Kubernetes tests in a dedicated package offers multiple benefits:

Better test ownership and isolation of Kubernetes-specific test logic.
With this PR and the introduction of the dedicated TestMain, we unlock further future improvements for developer velocity:
- We can load container images into the kind cluster only once per test run.
- We can render Kustomize YAML manifests once upfront, avoiding per-test Kustomize render calls which are prone to network-transient failures.

Checklist

I have read and understood the pull request guidelines of this project.
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in ./changelog/fragments using the changelog tool
I have added an integration test or an E2E test

Disruptive User Impact

No user-facing disruption; internal test structure change only.

How to test this PR locally

EXTERNAL=true SNAPSHOT=true PACKAGES=docker DOCKER_VARIANTS=basic PLATFORMS=linux/arm64 mage package

INSTANCE_PROVISIONER="kind" TEST_PLATFORMS="kubernetes/arm64/1.33.0/basic" mage integration:TestKubernetes

Related issues

elasticmachine · 2025-06-14T11:01:05Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: b9d6713

Failed CI Steps

x86_64:sudo: install-uninstall

History

💛 Build #22375 was flaky c1aebce
💔 Build #22358 failed 0044f91

cc @pkoutsovasilis

elastic-sonarqube · 2025-06-14T14:10:16Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

elasticmachine · 2025-06-16T07:08:38Z

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

pchila

LGTM 🚀

swiatekm

Noice.

v1v

LGTM, just a super nit comment with a super nit improvement 👼

.buildkite/scripts/steps/k8s-extended-tests.sh

github-actions · 2025-06-17T05:01:01Z

@Mergifyio backport 8.17 8.18 8.19 9.0

mergify · 2025-06-17T05:01:10Z

backport 8.17 8.18 8.19 9.0

✅ Backports have been created

#8546 [8.17] (backport #8484) [test] split up k8s integration tests has been created for branch 8.17 but encountered conflicts
#8547 [8.18] (backport #8484) [test] split up k8s integration tests has been created for branch 8.18 but encountered conflicts
#8548 [8.19] (backport #8484) [test] split up k8s integration tests has been created for branch 8.19 but encountered conflicts
#8549 [9.0] (backport #8484) [test] split up k8s integration tests has been created for branch 9.0 but encountered conflicts

* feat: split up k8s integration test in testing/integration/k8s package * feat: remove the need of a kubernetes build tag * feat: expand k8s integration step on failure (cherry picked from commit dd52e90) # Conflicts: # docs/test-framework-dev-guide.md # go.mod # magefile.go # testing/integration/beat_receivers_test.go # testing/integration/k8s/journald_test.go # testing/integration/k8s/kubernetes_agent_standalone_test.go # testing/integration/k8s/testdata/journald-input.yml # testing/integration/k8s/testdata/journald-otel.yml # testing/integration/otel_test.go

* feat: split up k8s integration test in testing/integration/k8s package * feat: remove the need of a kubernetes build tag * feat: expand k8s integration step on failure (cherry picked from commit dd52e90) # Conflicts: # magefile.go # testing/integration/k8s/journald_test.go # testing/integration/k8s/kubernetes_agent_standalone_test.go # testing/integration/k8s/testdata/journald-input.yml # testing/integration/k8s/testdata/journald-otel.yml

* feat: split up k8s integration test in testing/integration/k8s package * feat: remove the need of a kubernetes build tag * feat: expand k8s integration step on failure (cherry picked from commit dd52e90) # Conflicts: # go.mod # magefile.go # testing/integration/beat_receivers_test.go # testing/integration/k8s/journald_test.go # testing/integration/k8s/kubernetes_agent_standalone_test.go # testing/integration/k8s/testdata/journald-input.yml # testing/integration/k8s/testdata/journald-otel.yml

* [test] split up k8s integration tests (#8484) * feat: split up k8s integration test in testing/integration/k8s package * feat: remove the need of a kubernetes build tag * feat: expand k8s integration step on failure (cherry picked from commit dd52e90) # Conflicts: # docs/test-framework-dev-guide.md # go.mod # magefile.go # testing/integration/beat_receivers_test.go # testing/integration/k8s/journald_test.go # testing/integration/k8s/kubernetes_agent_standalone_test.go # testing/integration/k8s/testdata/journald-input.yml # testing/integration/k8s/testdata/journald-otel.yml # testing/integration/otel_test.go * fix: resolve conflicts * fix: remove irrelevant files * fix: update NOTICE.txt --------- Co-authored-by: Panos Koutsovasilis <[email protected]>

* [test] split up k8s integration tests (#8484) * feat: split up k8s integration test in testing/integration/k8s package * feat: remove the need of a kubernetes build tag * feat: expand k8s integration step on failure (cherry picked from commit dd52e90) # Conflicts: # go.mod # magefile.go # testing/integration/beat_receivers_test.go # testing/integration/k8s/journald_test.go # testing/integration/k8s/kubernetes_agent_standalone_test.go # testing/integration/k8s/testdata/journald-input.yml # testing/integration/k8s/testdata/journald-otel.yml * fix: resolve conflicts * fix: go mod tidy --------- Co-authored-by: Panos Koutsovasilis <[email protected]>

* feat: split up k8s integration test in testing/integration/k8s package * feat: remove the need of a kubernetes build tag * feat: expand k8s integration step on failure (cherry picked from commit dd52e90) # Conflicts: # magefile.go # testing/integration/k8s/journald_test.go # testing/integration/k8s/kubernetes_agent_standalone_test.go # testing/integration/k8s/testdata/journald-input.yml # testing/integration/k8s/testdata/journald-otel.yml

* [test] split up k8s integration tests (#8484) * feat: split up k8s integration test in testing/integration/k8s package * feat: remove the need of a kubernetes build tag * feat: expand k8s integration step on failure (cherry picked from commit dd52e90) # Conflicts: # magefile.go # testing/integration/k8s/journald_test.go # testing/integration/k8s/kubernetes_agent_standalone_test.go # testing/integration/k8s/testdata/journald-input.yml # testing/integration/k8s/testdata/journald-otel.yml * feat: move journald-input.yml * feat: remove journald-otel.yml --------- Co-authored-by: Panos Koutsovasilis <[email protected]>

* feat: split up k8s integration test in testing/integration/k8s package * feat: remove the need of a kubernetes build tag * feat: expand k8s integration step on failure (cherry picked from commit dd52e90) # Conflicts: # docs/test-framework-dev-guide.md # go.mod # magefile.go # testing/integration/beat_receivers_test.go # testing/integration/k8s/journald_test.go # testing/integration/k8s/kubernetes_agent_standalone_test.go # testing/integration/k8s/testdata/journald-input.yml # testing/integration/k8s/testdata/journald-otel.yml # testing/integration/otel_test.go

* [test] split up k8s integration tests (#8484) * feat: split up k8s integration test in testing/integration/k8s package * feat: remove the need of a kubernetes build tag * feat: expand k8s integration step on failure (cherry picked from commit dd52e90) # Conflicts: # docs/test-framework-dev-guide.md # go.mod # magefile.go # testing/integration/beat_receivers_test.go # testing/integration/k8s/journald_test.go # testing/integration/k8s/kubernetes_agent_standalone_test.go # testing/integration/k8s/testdata/journald-input.yml # testing/integration/k8s/testdata/journald-otel.yml # testing/integration/otel_test.go * fix: resolve conflicts * fix: remove irrelevant files --------- Co-authored-by: Panos Koutsovasilis <[email protected]>

pkoutsovasilis self-assigned this Jun 13, 2025

pkoutsovasilis added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog backport-active-all Automated backport with mergify to all the active branches labels Jun 13, 2025

pkoutsovasilis force-pushed the feat/split_up_k8s_integration_tests branch 5 times, most recently from eae684f to b9d6713 Compare June 14, 2025 09:32

pkoutsovasilis force-pushed the feat/split_up_k8s_integration_tests branch from b9d6713 to 6879538 Compare June 14, 2025 11:10

pkoutsovasilis added 3 commits June 14, 2025 16:08

feat: split up k8s integration test in testing/integration/k8s package

6e6d1b6

feat: remove the need of a kubernetes build tag

15b5016

feat: expand k8s integration step on failure

d6b76a0

pkoutsovasilis force-pushed the feat/split_up_k8s_integration_tests branch from 6879538 to d6b76a0 Compare June 14, 2025 13:08

pkoutsovasilis requested review from pchila and ycombinator June 16, 2025 07:08

pkoutsovasilis marked this pull request as ready for review June 16, 2025 07:08

pkoutsovasilis requested review from a team as code owners June 16, 2025 07:08

pchila approved these changes Jun 16, 2025

View reviewed changes

swiatekm approved these changes Jun 16, 2025

View reviewed changes

v1v approved these changes Jun 16, 2025

View reviewed changes

.buildkite/scripts/steps/k8s-extended-tests.sh Show resolved Hide resolved

ycombinator approved these changes Jun 16, 2025

View reviewed changes

pkoutsovasilis merged commit dd52e90 into elastic:main Jun 17, 2025
11 checks passed

mergify bot mentioned this pull request Jun 17, 2025

[8.17] (backport #8484) [test] split up k8s integration tests #8546

Merged

8 tasks

This was referenced Jun 17, 2025

[8.18] (backport #8484) [test] split up k8s integration tests #8547

Merged

[8.19] (backport #8484) [test] split up k8s integration tests #8548

Merged

mergify bot mentioned this pull request Jun 17, 2025

[9.0] (backport #8484) [test] split up k8s integration tests #8549

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[test] split up k8s integration tests #8484

[test] split up k8s integration tests #8484

Uh oh!

pkoutsovasilis commented Jun 13, 2025 •

edited

Loading

Uh oh!

elasticmachine commented Jun 14, 2025

Uh oh!

elastic-sonarqube bot commented Jun 14, 2025

Uh oh!

elasticmachine commented Jun 16, 2025

Uh oh!

pchila left a comment

Uh oh!

swiatekm left a comment

Uh oh!

v1v left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 17, 2025

Uh oh!

mergify bot commented Jun 17, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[test] split up k8s integration tests #8484

[test] split up k8s integration tests #8484

Uh oh!

Conversation

pkoutsovasilis commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Why is it important?

Checklist

Disruptive User Impact

How to test this PR locally

Related issues

Uh oh!

elasticmachine commented Jun 14, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

History

Uh oh!

elastic-sonarqube bot commented Jun 14, 2025

Quality Gate passed

Uh oh!

elasticmachine commented Jun 16, 2025

Uh oh!

pchila left a comment

Choose a reason for hiding this comment

Uh oh!

swiatekm left a comment

Choose a reason for hiding this comment

Uh oh!

v1v left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 17, 2025

Uh oh!

mergify bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pkoutsovasilis commented Jun 13, 2025 •

edited

Loading

mergify bot commented Jun 17, 2025 •

edited

Loading