-
Notifications
You must be signed in to change notification settings - Fork 197
[8.18] (backport #8484) [test] split up k8s integration tests #8547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Cherry-pick of dd52e90 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
depends on #8482 |
* feat: split up k8s integration test in testing/integration/k8s package * feat: remove the need of a kubernetes build tag * feat: expand k8s integration step on failure (cherry picked from commit dd52e90) # Conflicts: # docs/test-framework-dev-guide.md # go.mod # magefile.go # testing/integration/beat_receivers_test.go # testing/integration/k8s/journald_test.go # testing/integration/k8s/kubernetes_agent_standalone_test.go # testing/integration/k8s/testdata/journald-input.yml # testing/integration/k8s/testdata/journald-otel.yml # testing/integration/otel_test.go
7992dbf
to
4d44061
Compare
|
What does this PR do?
testing/integration/k8s
package.kubernetes
build tag; Kubernetes tests are now always compiled as part of the normalintegration
tag.TestMain
entrypoint in the new package, enabling centralized setup logic.integration:TestKubernetes
(formerlyintegration:Kubernetes
)integration:TestKubernetesMatrix
(formerlyintegration:KubernetesMatrix
)integration:TestKubernetesSingle
(formerlyintegration:KubernetesSingle
)journald_test.go
,kubernetes_agent_service_test.go
,kubernetes_agent_standalone_test.go
,otel_helm_test.go
, and their respective testdata).Why is it important?
This PR continues the ongoing effort of modularizing the ever-growing
integration
package as part of #8087. Specifically, it addresses the Kubernetes test split described in #8412.Having Kubernetes tests in a dedicated package offers multiple benefits:
TestMain
, we unlock further future improvements for developer velocity:Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
No user-facing disruption; internal test structure change only.
How to test this PR locally
Related issues
This is an automatic backport of pull request [test] split up k8s integration tests #8484 done by Mergify.