TestGetArtifactName: Add test case + cleanup unused fields
#8559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
the
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Merged
8 tasks
ycombinator
changed the title
TestGetArtifactName: Adding test cases / cleaning up unused fields
ycombinator
changed the title
TestGetArtifactName: Adding test cases / cleaning up unused fieldsTestGetArtifactName: Add test case + cleanup unused fields
|
swiatekm
approved these changes
Jun 17, 2025
💛 Build succeeded, but was flaky
Failed CI Stepscc @ycombinator |
simitt
approved these changes
Jun 17, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
(cherry picked from commit 0260c45) # Conflicts: # internal/pkg/agent/application/upgrade/artifact/artifact_test.go
ycombinator
added a commit
that referenced
this pull request
Jun 17, 2025
(cherry picked from commit 0260c45) # Conflicts: # internal/pkg/agent/application/upgrade/artifact/artifact_test.go Co-authored-by: Shaunak Kashyap <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up to #7804, this PR cleans up unused fields and adds a test case to the
TestGetArtifactNameunit test introduced in that PR.