-
Notifications
You must be signed in to change notification settings - Fork 23
fix(deps): update dependency com.openai:openai-java to v2.12.0 #697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like a small breaking change in the client: i guess this was unintentionally breaking, so let's wait and see if they provide a patch release before we do anything here |
d3674d2 to
96015c0
Compare
ef20328
96015c0 to
ef20328
Compare
ef20328 to
ee538ee
Compare
ee538ee to
c1dca48
Compare
c1dca48 to
e95b638
Compare
e95b638 to
e4d1c31
Compare
…vate/com.openai-openai-java-2.x
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
| @Advice.Return OpenAIClient result, | ||
| @Advice.FieldValue("clientOptions") ClientOptions.Builder clientOptions) { | ||
| return InstrumentedOpenAiClient.wrap(result).baseUrl(clientOptions.baseUrl()).build(); | ||
| return InstrumentedOpenAiClient.wrap(result).baseUrl(clientOptions.build().baseUrl()).build(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[for reviewer] this means the builder .build() method will be executed twice, but a quick look at the implementation indicates that there isn't any non-idempotent operation in it, which means it should be fine.
|
after a few minor releases this breaking change remains, so I've implemented a workaround that should work with both new and older versions in e01d14d |
This PR contains the following updates:
2.7.0->2.12.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
openai/openai-java (com.openai:openai-java)
v2.12.0Full Changelog: v2.11.0...v2.12.0
Features
Bug Fixes
withOptionsusage when original is gc'd (e0890e3)Chores
Documentation
Refactors
ClientOptionsTestchange (a7379a2)v2.11.0Full Changelog: v2.10.0...v2.11.0
Features
Chores
v2.10.0Full Changelog: v2.9.1...v2.10.0
Features
Bug Fixes
Chores
v2.9.1Full Changelog: v2.9.0...v2.9.1
Chores
v2.9.0Full Changelog: v2.8.1...v2.9.0
Features
Bug Fixes
v2.8.1Full Changelog: v2.8.0...v2.8.1
Bug Fixes
v2.8.0Full Changelog: v2.7.0...v2.8.0
Features
Bug Fixes
Chores
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.