Skip to content

fix(deps): update dependency com.openai:openai-java to v2.12.0 #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SylvainJuge merged 3 commits into from
Jul 2, 2025
Merged

fix(deps): update dependency com.openai:openai-java to v2.12.0 #697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4d1c31
fix(deps): update dependency com.openai:openai-java to v2.12.0
elastic-renovate-prod[bot] Jul 1, 2025
e01d14d
fix compilation error
SylvainJuge Jul 2, 2025
8127aff
Merge branch 'main' of github.com:elastic/elastic-otel-java into reno…
SylvainJuge Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ log4j2-slf4j = { group= "org.apache.logging.log4j", name="log4j-slf4j2-impl", ve
log4j2-core = { group= "org.apache.logging.log4j", name="log4j-core", version.ref="log4j2"}

# Instrumented libraries
openaiClient = "com.openai:openai-java:2.7.0"
openaiClient = "com.openai:openai-java:2.12.0"

[bundles]

Expand Down
2 changes: 1 addition & 1 deletion ...1/src/main/java/co/elastic/otel/openai/v1_1/OpenAiOkHttpClientBuilderInstrumentation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public static class AdviceClass {
public static OpenAIClient onExit(
@Advice.Return OpenAIClient result,
@Advice.FieldValue("clientOptions") ClientOptions.Builder clientOptions) {
return InstrumentedOpenAiClient.wrap(result).baseUrl(clientOptions.baseUrl()).build();
return InstrumentedOpenAiClient.wrap(result).baseUrl(clientOptions.build().baseUrl()).build();
Copy link
Member

@SylvainJuge SylvainJuge Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[for reviewer] this means the builder .build() method will be executed twice, but a quick look at the implementation indicates that there isn't any non-idempotent operation in it, which means it should be fine.

}
}
}
Loading