Silence LogRecord SDK deprecation warnings #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
commented
Oct 2, 2025
...tic-opentelemetry-instrumentation-openai/src/opentelemetry/instrumentation/openai/helpers.py
Show resolved
Hide resolved
xrmx
force-pushed
the
try-to-silence-deprecation-warnings
branch
from
40e398c to
79c66bd
Compare
Pass the full context instead of the deprecated trace_id, span_id and trace_flags.
Unfortunately the deprecation raises everytime we emit a message event because of internal sdk code even if we don't pass the deprecated parameters ourselves. So silence it.
xrmx
force-pushed
the
try-to-silence-deprecation-warnings
branch
from
79c66bd to
bea6915
Compare
anuraaga
approved these changes
Oct 3, 2025
| try: | ||
| from opentelemetry.sdk._logs._internal import LogDeprecatedInitWarning | ||
|
|
||
| warnings.simplefilter("ignore", LogDeprecatedInitWarning) |
There was a problem hiding this comment.
To confirm, even though we updated to the new form we still need to suppress it?
There was a problem hiding this comment.
Yes, all the code that is emitting API LogRecords will get these warnings because the LogRecord conversion code need to pass these deprecated fields to not break the Event API that is still using these fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This is a followup of #90 where the newer OTel sdks introduced a warning everytime you emit a LogRecord:
Related issues