Skip to content

Silence LogRecord SDK deprecation warnings #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2025
Merged

Silence LogRecord SDK deprecation warnings #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e61f1c
openai: pass the context when contructing the event from stream choices
xrmx Oct 2, 2025
bea6915
openai: silence LogRecord construction warnings
xrmx Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...opentelemetry-instrumentation-openai/src/opentelemetry/instrumentation/openai/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import logging
import os
import warnings
from timeit import default_timer
from typing import Collection

Expand Down Expand Up @@ -62,6 +63,15 @@
logger = logging.getLogger(__name__)


# silence warnings from OTel sdk LogRecord conversion
try:
from opentelemetry.sdk._logs._internal import LogDeprecatedInitWarning

warnings.simplefilter("ignore", LogDeprecatedInitWarning)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To confirm, even though we updated to the new form we still need to suppress it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, all the code that is emitting API LogRecords will get these warnings because the LogRecord conversion code need to pass these deprecated fields to not break the Event API that is still using these fields.

except ImportError:
pass


class OpenAIInstrumentor(BaseInstrumentor):
def instrumentation_dependencies(self) -> Collection[str]:
return _instruments
Expand Down
18 changes: 6 additions & 12 deletions ...-opentelemetry-instrumentation-openai/src/opentelemetry/instrumentation/openai/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,16 @@
from timeit import default_timer
from typing import TYPE_CHECKING, Optional

from opentelemetry import context
from opentelemetry._logs import Logger, LogRecord
from opentelemetry.metrics import Histogram
from opentelemetry.semconv._incubating.attributes.gen_ai_attributes import (
GEN_AI_OPENAI_REQUEST_SERVICE_TIER,
GEN_AI_OPENAI_RESPONSE_SERVICE_TIER,
GEN_AI_OPERATION_NAME,
GEN_AI_OUTPUT_TYPE,
GEN_AI_REQUEST_CHOICE_COUNT,
GEN_AI_REQUEST_ENCODING_FORMATS,
GEN_AI_REQUEST_FREQUENCY_PENALTY,
GEN_AI_REQUEST_MAX_TOKENS,
GEN_AI_REQUEST_MODEL,
Expand All @@ -43,15 +46,8 @@
)
from opentelemetry.semconv.attributes.error_attributes import ERROR_TYPE
from opentelemetry.semconv.attributes.server_attributes import SERVER_ADDRESS, SERVER_PORT

try:
from opentelemetry.semconv._incubating.attributes.gen_ai_attributes import GEN_AI_REQUEST_ENCODING_FORMATS
except ImportError:
# available since 1.29.0
GEN_AI_REQUEST_ENCODING_FORMATS = "gen_ai.request.encoding_formats"

from opentelemetry.metrics import Histogram
from opentelemetry.trace import Span
from opentelemetry.trace.propagation import set_span_in_context
from opentelemetry.util.types import Attributes

EVENT_GEN_AI_ASSISTANT_MESSAGE = "gen_ai.assistant.message"
Expand Down Expand Up @@ -380,15 +376,13 @@ def _send_logs_from_stream_choices(
"message": message,
}
# StreamWrapper is consumed after start_as_current_span exits, so capture the current span
ctx = span.get_span_context()
ctx = set_span_in_context(span, context.get_current())
# keep compat on the exported attributes with Event
log = LogRecord(
event_name=EVENT_GEN_AI_CHOICE,
body=body,
attributes={**attributes, "event.name": EVENT_GEN_AI_CHOICE},
trace_id=ctx.trace_id,
span_id=ctx.span_id,
trace_flags=ctx.trace_flags,
context=ctx,
)
logger.emit(log)

Expand Down