Skip to content

Conversation

swallez
Copy link
Member

@swallez swallez commented Nov 13, 2024

A took property was added in ES 8.16, which caused EsqlAdapterBase.readHeader().

This PR fixes that, by handling took and also by ignoring unknown properties encountered before the values array.

Copy link
Contributor

@l-trotta l-trotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@l-trotta l-trotta merged commit d130ce5 into main Nov 14, 2024
7 checks passed
@l-trotta l-trotta deleted the fix-esql-adapter branch November 14, 2024 16:55
github-actions bot pushed a commit that referenced this pull request Nov 14, 2024
l-trotta added a commit that referenced this pull request Nov 18, 2024
github-actions bot pushed a commit that referenced this pull request Nov 19, 2024
l-trotta added a commit that referenced this pull request Nov 19, 2024
livebcdev0603 added a commit to livebcdev0603/elasticsearch-java-client-demo that referenced this pull request Apr 10, 2025
adrianliu0603 added a commit to adrianliu0603/elasticsearch-java-client-demo that referenced this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants