Skip to content

Conversation

@xrmx
Copy link
Member

@xrmx xrmx commented Mar 17, 2025

This is untested

@xrmx xrmx requested a review from estolfo March 17, 2025 14:02
@codefromthecrypt
Copy link
Contributor

codefromthecrypt commented Mar 17, 2025

ok I think it should remove the bedrock code in llm python around langtrace and test. I need to focus for my workshop today, but can try it tomorrow

@estolfo
Copy link

estolfo commented Mar 18, 2025

I tested this and looks good:

image

trace document:

{
  "_index": ".ds-traces-apm-default-2025.03.12-000001",
  "_id": "RjaWpJUBi8PGTiyyBibT",
  "_version": 1,
  "_source": {
    "parent": {
      "id": "d1e8d4fc101e00ab"
    },
    "agent": {
      "name": "opentelemetry/python/elastic",
      "version": "0.8.0"
    },
    "processor": {
      "event": "span"
    },
    "url": {},
    "labels": {
      "process_runtime_description": "3.12.0 (v3.12.0:0fb18b02c8, Oct  2 2023, 09:45:56) [Clang 13.0.0 (clang-1300.0.29.30)]",
      "gen_ai_response_finish_reasons": [
        "end_turn"
      ],
      "aws_region": "us-east-1",
      "gen_ai_operation_name": "chat",
      "gen_ai_request_model": "anthropic.claude-v2",
      "aws_request_id": "3deb7386-abde-4cfb-a2ba-ae86c2b94aab",
      "gen_ai_system": "aws.bedrock",
      "telemetry_auto_version": "0.52b0"
    },
    "observer": {
      "hostname": "3b7124bccf0c",
      "type": "apm-server",
      "version": "8.17.2"
    },
    "trace": {
      "id": "de3086132df2e350013afe1c407bb37c"
    },
    "@timestamp": "2025-03-17T14:50:29.102Z",
    "data_stream": {
      "namespace": "default",
      "type": "traces",
      "dataset": "apm"
    },
    "numeric_labels": {
      "gen_ai_request_max_tokens": 1024,
      "gen_ai_usage_input_tokens": 1926,
      "gen_ai_request_temperature": 0,
      "gen_ai_usage_output_tokens": 194,
      "retry_attempts": 0
    },
    "service": {
      "framework": {
        "name": "opentelemetry.instrumentation.botocore.bedrock-runtime",
        "version": "0.52b0"
      },
      "name": "openai-example",
      "runtime": {
        "name": "cpython",
        "version": "3.12.0"
      },
      "language": {
        "name": "python"
      },
      "target": {
        "name": "Bedrock Runtime",
        "type": "aws-api"
      }
    },
    "host": {
      "os": {
        "type": "macos",
        "version": "24.3.0",
        "platform": "darwin"
      }
    },
    "http": {
      "response": {
        "status_code": 200
      }
    },
    "event": {
      "ingested": "2025-03-17T14:50:50Z",
      "success_count": 1,
      "outcome": "success"
    },
    "span": {
      "duration": {
        "us": 18085699
      },
      "representative_count": 1,
      "subtype": "aws-api",
      "destination": {
        "service": {
          "resource": ":0",
          "name": ":0",
          "type": "external"
        }
      },
      "name": "chat anthropic.claude-v2",
      "id": "b07688de8c7e8d8f",
      "type": "external"
    },
    "timestamp": {
      "us": 1742223029102444
    }
  },
  "fields": {
    "labels.process_runtime_description": [
      "3.12.0 (v3.12.0:0fb18b02c8, Oct  2 2023, 09:45:56) [Clang 13.0.0 (clang-1300.0.29.30)]"
    ],
    "numeric_labels.retry_attempts": [
      0
    ],
    "service.target.name.text": [
      "Bedrock Runtime"
    ],
    "service.language.name": [
      "python"
    ],
    "labels.aws_request_id": [
      "3deb7386-abde-4cfb-a2ba-ae86c2b94aab"
    ],
    "labels.telemetry_auto_version": [
      "0.52b0"
    ],
    "agent.name.text": [
      "opentelemetry/python/elastic"
    ],
    "host.os.version": [
      "24.3.0"
    ],
    "processor.event": [
      "span"
    ],
    "labels.gen_ai_system": [
      "aws.bedrock"
    ],
    "span.name.text": [
      "chat anthropic.claude-v2"
    ],
    "agent.name": [
      "opentelemetry/python/elastic"
    ],
    "http.response.status_code": [
      200
    ],
    "event.outcome": [
      "success"
    ],
    "host.os.type": [
      "macos"
    ],
    "service.language.name.text": [
      "python"
    ],
    "service.runtime.name.text": [
      "cpython"
    ],
    "service.runtime.version": [
      "3.12.0"
    ],
    "span.id": [
      "b07688de8c7e8d8f"
    ],
    "data_stream.type": [
      "traces"
    ],
    "span.type": [
      "external"
    ],
    "timestamp.us": [
      1742223029102444
    ],
    "observer.type": [
      "apm-server"
    ],
    "observer.version": [
      "8.17.2"
    ],
    "service.name.text": [
      "openai-example"
    ],
    "agent.version": [
      "0.8.0"
    ],
    "parent.id": [
      "d1e8d4fc101e00ab"
    ],
    "span.destination.service.name": [
      ":0"
    ],
    "labels.gen_ai_request_model": [
      "anthropic.claude-v2"
    ],
    "span.representative_count": [
      1
    ],
    "span.destination.service.type": [
      "external"
    ],
    "span.name": [
      "chat anthropic.claude-v2"
    ],
    "service.framework.version": [
      "0.52b0"
    ],
    "trace.id": [
      "de3086132df2e350013afe1c407bb37c"
    ],
    "span.duration.us": [
      18085699
    ],
    "numeric_labels.gen_ai_usage_output_tokens": [
      194
    ],
    "event.success_count": [
      1
    ],
    "numeric_labels.gen_ai_request_max_tokens": [
      1024
    ],
    "labels.aws_region": [
      "us-east-1"
    ],
    "service.target.type": [
      "aws-api"
    ],
    "numeric_labels.gen_ai_request_temperature": [
      0
    ],
    "service.name": [
      "openai-example"
    ],
    "service.framework.name": [
      "opentelemetry.instrumentation.botocore.bedrock-runtime"
    ],
    "data_stream.namespace": [
      "default"
    ],
    "service.runtime.name": [
      "cpython"
    ],
    "labels.gen_ai_response_finish_reasons": [
      "end_turn"
    ],
    "span.subtype": [
      "aws-api"
    ],
    "service.target.name": [
      "Bedrock Runtime"
    ],
    "observer.hostname": [
      "3b7124bccf0c"
    ],
    "service.framework.name.text": [
      "opentelemetry.instrumentation.botocore.bedrock-runtime"
    ],
    "labels.gen_ai_operation_name": [
      "chat"
    ],
    "span.destination.service.name.text": [
      ":0"
    ],
    "event.ingested": [
      "2025-03-17T14:50:50.000Z"
    ],
    "@timestamp": [
      "2025-03-17T14:50:29.102Z"
    ],
    "host.os.platform": [
      "darwin"
    ],
    "data_stream.dataset": [
      "apm"
    ],
    "numeric_labels.gen_ai_usage_input_tokens": [
      1926
    ],
    "span.destination.service.resource": [
      ":0"
    ]
  }
}

Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the redundant bedrock instrumentation and tests fine. notably you can see logs, traces and metrics here:
Screenshot 2025-03-18 at 7 46 14 AM
Screenshot 2025-03-18 at 7 47 00 AM
Screenshot 2025-03-18 at 7 47 07 AM

@codefromthecrypt codefromthecrypt merged commit 7c40c13 into main Mar 18, 2025
2 checks passed
@codefromthecrypt codefromthecrypt deleted the update-edot-chatbot branch March 18, 2025 11:49
@codefromthecrypt
Copy link
Contributor

thanks @xrmx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants