Skip to content

Conversation

@quux00
Copy link
Contributor

@quux00 quux00 commented Sep 5, 2025

Adds the project_routing query param to the _search and _async_search endpoints
but only in serverless behind the feature flag "serverless.cross_project.enabled".
This param is not available in stateful ("stack").

@quux00 quux00 added specification skip-backport This pull request should not be backported labels Sep 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

@quux00 quux00 marked this pull request as ready for review September 5, 2025 16:18
@quux00 quux00 requested a review from a team as a code owner September 5, 2025 16:18
@l-trotta
Copy link
Contributor

@quux00 thanks! waiting for the server side PR to be merged. just to be sure, is the only value allowed _alias:something? would it make sense to have the user only input the customizable part of the string?

* _alias:_origin
* _alias:*pr*
* Supported in serverless only.
* @availability serverless
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see these on another PR:

@availability serverless stability=stable visibility=public

Do I need to add those? What are the other possible values?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are optional, but nice to have. possible values:

  • stability: stable, experimental, unknown
  • visibility: public, private, feature_flag

in case of visibility=feature_flag you can also add an optional feature_flag={name of the feature flag}.
lastly there's since, which indicates (for stack) the version where the endpoint/field was introduced.
complete example:

* @availability stack since=8.4.0 visibility=feature_flag feature_flag=es.index_mode_feature_flag_registered

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it thanks. I'll add that in the next push.

@quux00 quux00 requested a review from JoshMock September 12, 2025 13:56
@quux00
Copy link
Contributor Author

quux00 commented Sep 12, 2025

@l-trotta

is the only value allowed _alias:something? would it make sense to have the user only input the customizable part of the string?

For now that is the only allowed entry, but in the future we will allow arbitrary key/value pairs with AND/OR/NOT booleans and boolean groupings, using Lucene query syntax, so I don't think we want additional constraints in the spec.

Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quux00 is this all the APIs we know of for now that will support CPS project routing rules? If not, the sooner we get those into the spec the better, as they'll be necessary to support the middleware Kibana needs.

Otherwise, LGTM.

@pquentin
Copy link
Member

@JoshMock There's #5277 too!

@quux00
Copy link
Contributor Author

quux00 commented Sep 15, 2025

s this all the APIs we know of for now that will support CPS project routing rules? If not, the sooner we get those into the spec the better, as they'll be necessary to support the middleware Kibana needs.

No, there are several more. Those PR(s) will be out later this week.

@quux00 quux00 merged commit f5e72ea into main Sep 15, 2025
8 checks passed
@quux00 quux00 deleted the search/project-routing branch September 15, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-backport This pull request should not be backported specification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants