Use deprecation logger for CLDR date format specifiers #112917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoop
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
reviewed
Sep 16, 2024
| // check for all textual fields, and localized zone offset | ||
| private static final Predicate<String> CONTAINS_CHANGING_TEXT_SPECIFIERS = System.getProperty("java.locale.providers", "") | ||
| .contains("COMPAT") ? Pattern.compile("[EcGaO]|MMM|LLL|eee|ccc|QQQ|ZZZZ").asPredicate() : Predicates.never(); | ||
| .contains("COMPAT") ? Pattern.compile("[BEGOavz]|LLL|MMM|QQQ|ccc|eee|Z{4}").asPredicate() : Predicates.never(); |
There was a problem hiding this comment.
What is B? Should v be upper case (time-zone ID)?
There was a problem hiding this comment.
Can we have tests with these formats in DateUtilsTests to ensure we are checking/interpreting them correctly?
There was a problem hiding this comment.
B is 'Period of day' ('in the morning'). v is generic time-zone name (V is time-zone id), which I've seen can be localised
Update some tests
thecoop
force-pushed
the
cldr-deprecation
branch
from
b6ec7cb to
190632d
Compare
|
@elasticmachine rerun elasticsearch-ci/7.17.25 |
|
@elasticmachine update branch |
thecoop
added
auto-backport
💚 Backport successful
|
thecoop
added a commit
to thecoop/elasticsearch
that referenced
this pull request
Sep 19, 2024
The addition of the logger requires several updates to tests to deal with the possible warning, or muting if there is not way to specify an allowed (but not mandatory) warning
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 19, 2024
…3190) The addition of the logger requires several updates to tests to deal with the possible warning, or muting if there is not way to specify an allowed (but not mandatory) warning Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the deprecation logger so warnings end up in Kibana.
Update regex for a few more textual specifiers.
I've had to modify or mute several tests to deal with the extra deprecation warning this outputs