Making transport changes to enable component template substitutions in the simulate ingest API #113063
Conversation
…n the simulate ingest API
masseyke
added
>non-issue
:Data Management/Ingest Node
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
…mponent-templates
…mponent-templates
| assert (bulkRequest instanceof SimulateBulkRequest) == false | ||
| : "TransportBulkAction should never be called with a SimulateBulkRequest"; |
There was a problem hiding this comment.
Should we also add an assert that there are no template substitutions here? I.e., that getComponentTemplateSubstitutions() returns an empty map?
| } | ||
|
|
||
| Builder(Metadata metadata) { | ||
| public Builder(Metadata metadata) { |
There was a problem hiding this comment.
I think we want this to remain protected, favoring .builder(otherMeta) instead
There was a problem hiding this comment.
Oh good point! I had missed that that method existed already.
| final DocWriteRequest<?> originalRequest, | ||
| final IndexRequest indexRequest, | ||
| final Metadata metadata, | ||
| Map<String, ComponentTemplate> templateSubstitutions |
There was a problem hiding this comment.
Should we call this var componentTemplateSubstitutions since that's the name we've used elsewhere? (and presumably we'll have to add one for index template substitutions eventually)
There was a problem hiding this comment.
Yes definitely. I missed that one when I renamed all the rest.
…mponent-templates
…mponent-templates
…mponent-templates
…mponent-templates
…mponent-templates
masseyke
deleted the
adding-transport-code-for-simulate-ingest-component-templates
branch
…n the simulate ingest API (elastic#113063)
3 participants
This is the second of three PRs that will result in the addition of component template substitutions support to the simulate ingest API. See the draft PR at #112762 for the full idea.
This PR updates TransportAbstractBulkAction and TransportSimulateBulkAction to use the substitute component templates that were added to BulkRequest in #112957.
The next PR will finish the rest layer, add the full documentation, and add rest-level testing.