[DOCS][ESQL] Add link to date_trunc docs, update tests #113263
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leemthompo
added
>docs
|
Documentation preview: |
elasticsearchmachine
added
Team:Docs
|
Pinging @elastic/es-docs (Team:Docs) |
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
alex-spies
requested changes
Sep 20, 2024
There was a problem hiding this comment.
Sorry @leemthompo , I think our doc generation mechanism makes this hard. But as it currently is, the description ends up both in our docs and in META functions, and the latter makes no sense to have asciidoc links :/
| date_format |[dateFormat, date] |["keyword|text", date] |[Date format (optional). If no format is specified\, the `yyyy-MM-dd'T'HH:mm:ss.SSSZ` format is used. If `null`\, the function returns `null`., Date expression. If `null`\, the function returns `null`.] | ||
| date_parse |[datePattern, dateString] |["keyword|text", "keyword|text"] |[The date format. Refer to the https://docs.oracle.com/en/java/javase/14/docs/api/java.base/java/time/format/DateTimeFormatter.html[`DateTimeFormatter` documentation] for the syntax. If `null`\, the function returns `null`., Date expression as a string. If `null` or an empty string\, the function returns `null`.] | ||
| date_trunc |[interval, date] |["date_period|time_duration", date] |[Interval; expressed using the timespan literal syntax., Date expression] | ||
| date_trunc |[interval, date] |["date_period|time_duration", date] |[Interval; expressed using the <<esql-timespan-literals\,timespan literal syntax>>., Date expression] |
There was a problem hiding this comment.
Oh no, the link is spilling into META functions. This is a general ESQL command, which is unaware of our docs or links to them :/
There was a problem hiding this comment.
thanks @alex-spies I kinda opened this as an experiment because unfamiliar with this workflow, is there a way to workaround this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@not-napoleon flagged that link was missing here, so I went down the test generation rabbit hole which I had lost all memory of